Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6247: [Java] Provide a common interface for float4 and float8 vectors #5132

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
* float values which could be null. A validity buffer (bit vector) is
* maintained to track which elements in the vector are null.
*/
public class Float4Vector extends BaseFixedWidthVector {
public class Float4Vector extends BaseFixedWidthVector implements FloatingPointVector {
public static final byte TYPE_WIDTH = 4;
private final FieldReader reader;

Expand Down Expand Up @@ -282,6 +282,20 @@ public static float get(final ArrowBuf buffer, final int index) {
return buffer.getFloat(index * TYPE_WIDTH);
}

@Override
public void setWithPossibleTruncate(int index, double value) {
set(index, (float) value);
}

@Override
public void setSafeWithPossibleTruncate(int index, double value) {
setSafe(index, (float) value);
}

@Override
public double getValueAsDouble(int index) {
return get(index);
}

/*----------------------------------------------------------------*
| |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
* double values which could be null. A validity buffer (bit vector) is
* maintained to track which elements in the vector are null.
*/
public class Float8Vector extends BaseFixedWidthVector {
public class Float8Vector extends BaseFixedWidthVector implements FloatingPointVector {
public static final byte TYPE_WIDTH = 8;
private final FieldReader reader;

Expand Down Expand Up @@ -283,6 +283,20 @@ public static double get(final ArrowBuf buffer, final int index) {
return buffer.getDouble(index * TYPE_WIDTH);
}

@Override
public void setWithPossibleTruncate(int index, double value) {
set(index, value);
}

@Override
public void setSafeWithPossibleTruncate(int index, double value) {
setSafe(index, value);
}

@Override
public double getValueAsDouble(int index) {
return get(index);
}

/*----------------------------------------------------------------*
| |
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.arrow.vector;

/**
* The interface for vectors with floating point values.
*/
public interface FloatingPointVector {

/**
* Sets the value at the given index, note this value may be truncated internally.
* @param index the index to set.
* @param value the value to set.
*/
void setWithPossibleTruncate(int index, double value);

/**
* Sets the value at the given index, note this value may be truncated internally.
* Any expansion/reallocation is handled automatically.
* @param index the index to set.
* @param value the value to set.
*/
void setSafeWithPossibleTruncate(int index, double value);

/**
* Gets the value at the given index.
* @param index the index to retrieve the value.
* @return the value at the index.
*/
double getValueAsDouble(int index);
}