Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-5960: [C++] Fix Boost dependencies link order #5205

Closed
wants to merge 1 commit into from
Closed

ARROW-5960: [C++] Fix Boost dependencies link order #5205

wants to merge 1 commit into from

Conversation

ingomueller-net
Copy link
Contributor

This reflects the dependency of these libraries, see ARROW-5960.

@ingomueller-net
Fix link order to boost::filesystem --> boost::system.
5e100ed 
This reflects the dependency of these libraries, see ARROW-5960.
@fsaintjacques fsaintjacques changed the title Fix link order to boost::filesystem --> boost::system. ARROW-5960: [C++] Fix link order to boost::filesystem --> boost::system. Aug 27, 2019
@fsaintjacques fsaintjacques changed the title ARROW-5960: [C++] Fix link order to boost::filesystem --> boost::system. ARROW-5960: [C++] Fix Boost dependencies link order Aug 27, 2019
pitrou
pitrou approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, looks harmless in any case. Will wait for CI to pass, though.

wesm
wesm approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pitrou pitrou closed this in 681817d Aug 27, 2019
@pitrou
Copy link
Member

pitrou commented Aug 27, 2019

Thank you @ingomueller-net !

@asfimport asfimport mentioned this pull request Aug 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesm wesm wesm approved these changes

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ingomueller-net @pitrou @wesm