ARROW-6435: [Python] Use pandas null coding consistently on List and Struct types #5302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesm
commented
Sep 5, 2019
| @@ -626,8 +644,82 @@ class ListConverter : public TypedConverter<TypeClass, ListConverter<TypeClass>> | |||
| } | |||
|
|
|||
| template <int NUMPY_TYPE, typename Type> | |||
| Status AppendNdarrayTypedItem(PyArrayObject* arr); | |||
| Status AppendNdarrayItem(PyObject* arr); | |||
| Status AppendNdarrayTypedItem(PyArrayObject* arr) { | |||
| #define LIST_SLOW_CASE(TYPE) \ | ||
| case Type::TYPE: { \ | ||
| return value_converter_->AppendMultiple(obj, value_length); \ | ||
| } |
| template <typename TypeClass, NullCoding null_coding> | ||
| class ListConverter | ||
| : public TypedConverter<TypeClass, ListConverter<TypeClass, null_coding>, | ||
| null_coding> { |
| } else { | ||
| *out = std::unique_ptr<SeqConverter>( | ||
| new StructConverter<NullCoding::NONE_ONLY>(from_pandas, strict_conversions)); | ||
| } |
|
OK, the Dask integration tests are passing again. Checking HDFS |
|
OK, HDFS docker-compose job passing also now |
|
@ursabot crossbow test docker-hdfs-integration docker-dask-integration |
|
AMD64 Conda Crossbow (#59368) builder has been succeeded. Revision: 68b8443 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-150
|
|
@ursabot crossbow test docker-hdfs-integration |
|
AMD64 Conda Crossbow (#59373) builder has been succeeded. Revision: 68b8443 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-155
|
|
The HDFS build was cancelled, don't know why. |
…y dictionary type
…ist or struct type and from_pandas=False
|
Rebased this and fixed the conflict from #5299 (which should not have been merged) |
This was referenced Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes ARROW-6434