ARROW-6475: [C++] Don't try to dictionary encode dictionary arrays#5299
Closed
bkietz wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-6475: [C++] Don't try to dictionary encode dictionary arrays#5299bkietz wants to merge 1 commit intoapache:masterfrom
bkietz wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Possible to have a unit test for this? |
Member
|
This is also coming up in ARROW-6435. I'll add a unit test there. |
kszucs
approved these changes
Sep 6, 2019
kszucs
changed the title
Member
|
@kszucs why did you merge this? |
Member
|
This patch has no unit tests and I addressed the fix and the unit test in #5302 |
Member
|
Your builds were passing including the test. Sorry, I was hesitating whether I should close it, now I know the answer. |
This was referenced Sep 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #5077 (or possibly #4949) behavior with dictionary arrays changed, leaving the explicit call to DictionaryEncode() redundant @wesm