ARROW-6562: [GLib] Fix returning wrong sliced data of GArrowBuffer #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not share the GBytes data of the original buffer with the sliced buffer because the sliced buffer has different offset and size with the original buffer. The sliced buffer should have reference to the original buffer. If we shouldn't have it, the original buffer may be freed when the sliced buffer is used. This change disables get_property of PROP_DATA. This is not related to this fix. But I include this change. Sorry. Users should use garrow_buffer_get_data() to get data instead of get_property of PROP_DATA. So we should not provide get_property of PROP_DATA.
kou
force-pushed
the
glib-buffer-fix-wrong-sliced-data
branch
from
9b6cc04
to
7ebea86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not share the GBytes data of the original buffer with the
sliced buffer because the sliced buffer has different offset and size
with the original buffer.
The sliced buffer should have reference to the original buffer. If we
shouldn't have it, the original buffer may be freed when the sliced
buffer is used.
This change disables get_property of PROP_DATA. This is not related to
this fix. But I include this change. Sorry.
Users should use garrow_buffer_get_data() to get data instead of
get_property of PROP_DATA. So we should not provide get_property of
PROP_DATA.