ARROW-6735: [C++] Suppress sign-compare warning with g++ 9.2.1 #5541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced by ARROW-6402 apache#5244 but removed accidentally by ARROW-5935 apache#4930. In file included from ../src/arrow/status.h:24, from ../src/arrow/memory_pool.h:26, from ../src/arrow/buffer.h:28, from ../src/arrow/array.h:28, from ../src/arrow/array/builder_union.h:25, from ../src/arrow/array/builder_union.cc:18: ../src/arrow/array/builder_union.cc: In constructor 'arrow::BasicUnionBuilder::BasicUnionBuilder(arrow::MemoryPool*, arrow::UnionMode::type, const std::vector<std::shared_ptr<arrow::ArrayBuilder> >&, const std::shared_ptr<arrow::DataType>&)': ../src/arrow/util/logging.h:86:55: error: comparison of integer expressions of different signedness: 'std::vector<arrow::ArrayBuilder*>::size_type' {aka 'long unsigned int'} and 'signed char' [-Werror=sign-compare] 86 | #define ARROW_CHECK_LT(val1, val2) ARROW_CHECK((val1) < (val2)) | ~~~~~~~^~~~~~~~ ../src/arrow/util/macros.h:43:52: note: in definition of macro 'ARROW_PREDICT_TRUE' 43 | #define ARROW_PREDICT_TRUE(x) (__builtin_expect(!!(x), 1)) | ^ ../src/arrow/util/logging.h:86:36: note: in expansion of macro 'ARROW_CHECK' 86 | #define ARROW_CHECK_LT(val1, val2) ARROW_CHECK((val1) < (val2)) | ^~~~~~~~~~~ ../src/arrow/util/logging.h:135:19: note: in expansion of macro 'ARROW_CHECK_LT' 135 | #define DCHECK_LT ARROW_CHECK_LT | ^~~~~~~~~~~~~~ ../src/arrow/array/builder_union.cc:63:3: note: in expansion of macro 'DCHECK_LT' 63 | DCHECK_LT(type_id_to_children_.size(), std::numeric_limits<int8_t>::max()); | ^~~~~~~~~
Codecov Report
@@ Coverage Diff @@
## master #5541 +/- ##
===========================================
+ Coverage 67.91% 89.21% +21.29%
===========================================
Files 600 773 +173
Lines 79093 113069 +33976
===========================================
+ Hits 53718 100874 +47156
+ Misses 25021 12195 -12826
+ Partials 354 0 -354
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced by ARROW-6402 #5244 but removed accidentally by
ARROW-5935 #4930.