Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-6735: [C++] Suppress sign-compare warning with g++ 9.2.1 #5541

Closed
wants to merge 1 commit into from
Closed

ARROW-6735: [C++] Suppress sign-compare warning with g++ 9.2.1 #5541

wants to merge 1 commit into from

Commits on Sep 29, 2019

  1. [C++] Suppress sign-compare warning with g++ 9.2.1 

    This was introduced by ARROW-6402 apache#5244 but removed accidentally by
ARROW-5935 apache#4930.

    In file included from ../src/arrow/status.h:24,
                     from ../src/arrow/memory_pool.h:26,
                     from ../src/arrow/buffer.h:28,
                     from ../src/arrow/array.h:28,
                     from ../src/arrow/array/builder_union.h:25,
                     from ../src/arrow/array/builder_union.cc:18:
    ../src/arrow/array/builder_union.cc: In constructor 'arrow::BasicUnionBuilder::BasicUnionBuilder(arrow::MemoryPool*, arrow::UnionMode::type, const std::vector<std::shared_ptr<arrow::ArrayBuilder> >&, const std::shared_ptr<arrow::DataType>&)':
    ../src/arrow/util/logging.h:86:55: error: comparison of integer expressions of different signedness: 'std::vector<arrow::ArrayBuilder*>::size_type' {aka 'long unsigned int'} and 'signed char' [-Werror=sign-compare]
       86 | #define ARROW_CHECK_LT(val1, val2) ARROW_CHECK((val1) < (val2))
          |                                                ~~~~~~~^~~~~~~~
    ../src/arrow/util/macros.h:43:52: note: in definition of macro 'ARROW_PREDICT_TRUE'
       43 | #define ARROW_PREDICT_TRUE(x) (__builtin_expect(!!(x), 1))
          |                                                    ^
    ../src/arrow/util/logging.h:86:36: note: in expansion of macro 'ARROW_CHECK'
       86 | #define ARROW_CHECK_LT(val1, val2) ARROW_CHECK((val1) < (val2))
          |                                    ^~~~~~~~~~~
    ../src/arrow/util/logging.h:135:19: note: in expansion of macro 'ARROW_CHECK_LT'
      135 | #define DCHECK_LT ARROW_CHECK_LT
          |                   ^~~~~~~~~~~~~~
    ../src/arrow/array/builder_union.cc:63:3: note: in expansion of macro 'DCHECK_LT'
       63 |   DCHECK_LT(type_id_to_children_.size(), std::numeric_limits<int8_t>::max());
          |   ^~~~~~~~~
    @kou
    kou committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    2094cca View commit details
    Browse the repository at this point in the history