ARROW-6835: [Archery][CMake] Restore ARROW_LINT_ONLY cmake option

[fsaintjacques]

No description provided.

[fsaintjacques]

@pitrou can you try locally to see if it restores your local script and also if archery works without conflict over CMAKE env var.

[pitrou]

ARROW_ONLY_LINT still doesn't work. I get the same double-conversion errors in CMake.

[pitrou]

As for archery lint, it now works, thank you :-)

I would have two suggestions though:

1. add domain-only options, e.g. I'd like to run archery lint --only-cpp --fix, and it would run and fix all C++ issues (but only them). Currently I have to disable all other linters by hand (they take some time and they may not be available, e.g. I don't have "hadolint" on my machine).
2. boolean options should not require an explicit boolean. It's weird to write --fix 1 instead of simply --fix.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-6835

[pitrou]

So, ARROW_ONLY_LINT isn't very important for me if archery lint works with minimal fuss and minimal runtime as currently.

[fsaintjacques]

As for archery lint, it now works, thank you :-)

I would have two suggestions though:

1. add domain-only options, e.g. I'd like to run archery lint --only-cpp --fix, and it would run and fix all C++ issues (but only them). Currently I have to disable all other linters by hand (they take some time and they may not be available, e.g. I don't have "hadolint" on my machine).

I just added a commit that will downgrade gracefully if a required binary (cmake, hadolint, flake8, cargo) is missing. It'll output a warning message and skip the linter. This should provide a better first experience than having to toggle options (thanks for being my guinea pig).

In the next iteration, I want to bring the detect-changes in archery so it can dynamically decide which linter to run by default invocation of archery lint. A second option I want to explore is a configuration file that toggles archery's default for some sub-commands, e.g. cmake options, linter options, etc.

2. boolean options should not require an explicit boolean. It's weird to write --fix 1 instead of simply --fix.

In my first draft, all boolean options were flags à-la autoconf (--with-clang-format/--without-clang-format). This is very convenient for humans, not so much for scripts. I decided to go with the --with-clang-format=X to ease porting CI scripts since we can do something like

archery lint --with-clang-format=${ARROW_CI_CPP_ENABLE} ...

This is much simpler than building argv via append and conditions (at least in bash).

[wesm]

+1