ARROW-101: Fix java compiler warnings #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java compiler emits several warnings regarding the use of raw types. This fixes the warnings by using generic types instead.
Java compiler emits some warning regarding unclosed resources. Those are vectors whose clear() method is called, but the compiler has no way to know that clear() and close() methods are equivalent.
|
Can you make the PR title exactly start with |
laurentgo
changed the title
|
I'm super new to Arrow might be coming from left field, but would it perhaps make sense to also add |
|
LGTM. |
|
+1 |
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 2, 2018
Author: Wes McKinney <wesm@apache.org> Closes apache#60 from wesm/PARQUET-525 and squashes the following commits: 04eea0f [Wes McKinney] Test various invalid files checked in reader-internal.cc.
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 4, 2018
Author: Wes McKinney <wesm@apache.org> Closes apache#60 from wesm/PARQUET-525 and squashes the following commits: 04eea0f [Wes McKinney] Test various invalid files checked in reader-internal.cc. Change-Id: Ic905a07237f7e0fc647a19d23e8cd9ff29a4c7df
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 6, 2018
Author: Wes McKinney <wesm@apache.org> Closes apache#60 from wesm/PARQUET-525 and squashes the following commits: 04eea0f [Wes McKinney] Test various invalid files checked in reader-internal.cc. Change-Id: Ic905a07237f7e0fc647a19d23e8cd9ff29a4c7df
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 7, 2018
Author: Wes McKinney <wesm@apache.org> Closes apache#60 from wesm/PARQUET-525 and squashes the following commits: 04eea0f [Wes McKinney] Test various invalid files checked in reader-internal.cc. Change-Id: Ic905a07237f7e0fc647a19d23e8cd9ff29a4c7df
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
Author: Wes McKinney <wesm@apache.org> Closes apache#60 from wesm/PARQUET-525 and squashes the following commits: 04eea0f [Wes McKinney] Test various invalid files checked in reader-internal.cc. Change-Id: Ic905a07237f7e0fc647a19d23e8cd9ff29a4c7df
xuechendi
pushed a commit
to xuechendi/arrow
that referenced
this pull request
Aug 4, 2020
Use Scanner::ScanWithWeakFilter
zhouyuan
pushed a commit
to zhouyuan/arrow
that referenced
this pull request
Dec 22, 2021
zhouyuan
added a commit
to zhouyuan/arrow
that referenced
this pull request
Jan 6, 2022
* Support casting boolean to bigint (apache#60) * remove log4j as it's not used (apache#61) Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> * Add stripe iteration support for batch_size reading in the ORC Scanner (apache#63) * Install re2 headers (apache#66) Co-authored-by: PHILO-HE <feilong.he@intel.com> Co-authored-by: zhixingheyi-tian <xiangxiang.shen@intel.com>
zhztheplayer
pushed a commit
to zhztheplayer/arrow-1
that referenced
this pull request
Feb 8, 2022
zhztheplayer
pushed a commit
to zhztheplayer/arrow-1
that referenced
this pull request
Mar 3, 2022
rui-mo
pushed a commit
to rui-mo/arrow-1
that referenced
this pull request
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several warnings emitted by java compiler regarding the use of raw types and unclosed resources.