ARROW-60: [C++] Struct type builder API #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengguangyuan
force-pushed
the
ARROW-60
branch
2 times, most recently
from
73eb5c2
to
b80cea2
Compare
|
Hi it looks like this change failed CI. Could you please make sure it passes? If you need help diagnosing the failure please post a comment. |
| @@ -71,6 +72,20 @@ Status MakeBuilder(MemoryPool* pool, const std::shared_ptr<DataType>& type, | |||
| } | |||
| } | |||
|
|
|||
| Status MakeStructBuilder(MemoryPool* pool, const std::shared_ptr<DataType>& type, | |||
| const std::vector<std::shared_ptr<Field>>& fields, | |||
There was a problem hiding this comment.
use FieldPtr you typedefed.
There was a problem hiding this comment.
Why are you defining this in terms of Fields instead of DataTypes? This is incongruent with other builder APIs I believe.
|
Can you make the build pass? There is a cpplint error |
|
@fengguangyuan can you rebase (due to ARROW-209) and let me know when the build is passing? Thank you |
added 5 commits
June 3, 2016 11:07
Implement the basic classes, StructArray and StructBuilder, meanwhile, add the perspective test cases for them. Other necessary methods will be added subsequetly.
Refine the previous committed patch. Add validate methods for testing StructArray and StructBuilder. TODO, Equals methods also need to be tested, but now it's not convient to do it.
Modify Validate() refered to the specification.
Add RangeEquals method to implement Equals method.
Add field index and TODO comment.
|
@wesm |
|
+1 thank you |
praveenbingo
added a commit
to praveenbingo/arrow
that referenced
this pull request
Aug 30, 2018
Exporting supported data types and functions from Gandiva. Added a JNI bridge to access this from the java layer.
praveenbingo
added a commit
to praveenbingo/arrow
that referenced
this pull request
Aug 30, 2018
Exporting supported data types and functions from Gandiva. Added a JNI bridge to access this from the java layer.
praveenbingo
added a commit
to praveenbingo/arrow
that referenced
this pull request
Aug 30, 2018
Exporting supported data types and functions from Gandiva. Added a JNI bridge to access this from the java layer.
praveenbingo
added a commit
to praveenbingo/arrow
that referenced
this pull request
Aug 30, 2018
Exporting supported data types and functions from Gandiva. Added a JNI bridge to access this from the java layer.
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 2, 2018
…ocalFileSource I also added the `file_descriptor` API so that we can verify that dtors elsewhere successfully close open files. Closes apache#56 Author: Wes McKinney <wesm@apache.org> Closes apache#66 from wesm/PARQUET-520 and squashes the following commits: 9d638ba [Wes McKinney] Add memory-mapping option to ParquetFileReader::OpenFile. Add --no-memory-map flag to parquet_reader 6389683 [Wes McKinney] Add Read API tests dbf6a45 [Wes McKinney] Test some failure modes for LocalFileSource / MemoryMapSource 01a7d64 [Wes McKinney] Add a MemoryMapSource and use this by default for SerializedFileReader
praveenbingo
added a commit
to praveenbingo/arrow
that referenced
this pull request
Sep 4, 2018
Exporting supported data types and functions from Gandiva. Added a JNI bridge to access this from the java layer.
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 4, 2018
…ocalFileSource I also added the `file_descriptor` API so that we can verify that dtors elsewhere successfully close open files. Closes apache#56 Author: Wes McKinney <wesm@apache.org> Closes apache#66 from wesm/PARQUET-520 and squashes the following commits: 9d638ba [Wes McKinney] Add memory-mapping option to ParquetFileReader::OpenFile. Add --no-memory-map flag to parquet_reader 6389683 [Wes McKinney] Add Read API tests dbf6a45 [Wes McKinney] Test some failure modes for LocalFileSource / MemoryMapSource 01a7d64 [Wes McKinney] Add a MemoryMapSource and use this by default for SerializedFileReader Change-Id: I467fcda7439d36c244d74bf5fec0ae61f6b674f0
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 6, 2018
…ocalFileSource I also added the `file_descriptor` API so that we can verify that dtors elsewhere successfully close open files. Closes apache#56 Author: Wes McKinney <wesm@apache.org> Closes apache#66 from wesm/PARQUET-520 and squashes the following commits: 9d638ba [Wes McKinney] Add memory-mapping option to ParquetFileReader::OpenFile. Add --no-memory-map flag to parquet_reader 6389683 [Wes McKinney] Add Read API tests dbf6a45 [Wes McKinney] Test some failure modes for LocalFileSource / MemoryMapSource 01a7d64 [Wes McKinney] Add a MemoryMapSource and use this by default for SerializedFileReader Change-Id: I467fcda7439d36c244d74bf5fec0ae61f6b674f0
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 7, 2018
…ocalFileSource I also added the `file_descriptor` API so that we can verify that dtors elsewhere successfully close open files. Closes apache#56 Author: Wes McKinney <wesm@apache.org> Closes apache#66 from wesm/PARQUET-520 and squashes the following commits: 9d638ba [Wes McKinney] Add memory-mapping option to ParquetFileReader::OpenFile. Add --no-memory-map flag to parquet_reader 6389683 [Wes McKinney] Add Read API tests dbf6a45 [Wes McKinney] Test some failure modes for LocalFileSource / MemoryMapSource 01a7d64 [Wes McKinney] Add a MemoryMapSource and use this by default for SerializedFileReader Change-Id: I467fcda7439d36c244d74bf5fec0ae61f6b674f0
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
…ocalFileSource I also added the `file_descriptor` API so that we can verify that dtors elsewhere successfully close open files. Closes apache#56 Author: Wes McKinney <wesm@apache.org> Closes apache#66 from wesm/PARQUET-520 and squashes the following commits: 9d638ba [Wes McKinney] Add memory-mapping option to ParquetFileReader::OpenFile. Add --no-memory-map flag to parquet_reader 6389683 [Wes McKinney] Add Read API tests dbf6a45 [Wes McKinney] Test some failure modes for LocalFileSource / MemoryMapSource 01a7d64 [Wes McKinney] Add a MemoryMapSource and use this by default for SerializedFileReader Change-Id: I467fcda7439d36c244d74bf5fec0ae61f6b674f0
praveenbingo
added a commit
to praveenbingo/arrow
that referenced
this pull request
Sep 10, 2018
Exporting supported data types and functions from Gandiva. Added a JNI bridge to access this from the java layer.
praveenbingo
added a commit
to praveenbingo/arrow
that referenced
this pull request
Sep 10, 2018
Exporting supported data types and functions from Gandiva. Added a JNI bridge to access this from the java layer.
zhouyuan
pushed a commit
to zhouyuan/arrow
that referenced
this pull request
Jan 4, 2022
zhouyuan
added a commit
to zhouyuan/arrow
that referenced
this pull request
Jan 6, 2022
* Support casting boolean to bigint (apache#60) * remove log4j as it's not used (apache#61) Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> * Add stripe iteration support for batch_size reading in the ORC Scanner (apache#63) * Install re2 headers (apache#66) Co-authored-by: PHILO-HE <feilong.he@intel.com> Co-authored-by: zhixingheyi-tian <xiangxiang.shen@intel.com>
zhztheplayer
pushed a commit
to zhztheplayer/arrow-1
that referenced
this pull request
Feb 8, 2022
zhztheplayer
pushed a commit
to zhztheplayer/arrow-1
that referenced
this pull request
Mar 3, 2022
rui-mo
pushed a commit
to rui-mo/arrow-1
that referenced
this pull request
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the basic classes,
StructArrayandStructBuilder,meanwhile,add the perspective test cases for them.
Other necessary methods will be added subsequently.