ARROW-7415: [C++][Dataset] implement IpcFormat #6162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Jan 13, 2020
| @@ -45,6 +45,7 @@ perf.data | |||
| perf.data.old | |||
|
|
|||
| cpp/.idea/ | |||
| .clangd/ | |||
There was a problem hiding this comment.
For my enlightenment, what is ".clangd"?
There was a problem hiding this comment.
.clangd/ is a cache directory used by the language server clangd. It powers autocompletion and other code awareness features
bkietz
force-pushed
the
7415-Dataset-Implement-IpcForm
branch
from
5997e75
to
30e5007
Compare
|
Passing Appveyor: https://ci.appveyor.com/project/BenjaminKietzman/arrow/builds/30079565 |
maartenb
pushed a commit
to maartenb/arrow
that referenced
this pull request
Jan 14, 2020
adds a basic IpcFormat and unit tests Closes apache#6162 from bkietz/7415-Dataset-Implement-IpcForm and squashes the following commits: 30e5007 <Benjamin Kietzman> review comments, clang-format 118787d <Benjamin Kietzman> lint fixes 3e7a7d4 <Benjamin Kietzman> ARROW-7415: Implement IpcFormat Authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a basic IpcFormat and unit tests