ARROW-8049: [C++] Upgrade bundled Thrift version to 0.13.0

[nealrichardson]

No description provided.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-8049

[wesm]

Hm, the GLib entry seems to have failed

CMake Error at /build/cpp/thrift_ep-prefix/src/thrift_ep-stamp/thrift_ep-configure-DEBUG.cmake:16 (message):
  Command failed: 1

   '/usr/bin/cmake' '-DCMAKE_C_COMPILER=/usr/lib/ccache/gcc' '-DCMAKE_CXX_COMPILER=/usr/lib/ccache/g++' '-DCMAKE_AR=/usr/bin/ar' '-DCMAKE_RANLIB=/usr/bin/ranlib' '-DCMAKE_BUILD_TYPE=DEBUG' '-DCMAKE_C_FLAGS= -ggdb -O0 -g -fPIC' '-DCMAKE_C_FLAGS_DEBUG= -ggdb -O0 -g -fPIC' '-DCMAKE_CXX_FLAGS= -fdiagnostics-color=always -ggdb -O0 -g -fPIC' '-DCMAKE_CXX_FLAGS_DEBUG= -fdiagnostics-color=always -ggdb -O0 -g -fPIC' '-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=' '-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=' '-DCMAKE_INSTALL_PREFIX=/build/cpp/thrift_ep/src/thrift_ep-install' '-DCMAKE_INSTALL_RPATH=/build/cpp/thrift_ep/src/thrift_ep-install/lib' '-DBUILD_COMPILER=OFF' '-DBUILD_SHARED_LIBS=OFF' '-DBUILD_TESTING=OFF' '-DBUILD_EXAMPLES=OFF' '-DBUILD_TUTORIALS=OFF' '-DWITH_QT4=OFF' '-DWITH_C_GLIB=OFF' '-DWITH_JAVA=OFF' '-DWITH_PYTHON=OFF' '-DWITH_HASKELL=OFF' '-DWITH_CPP=ON' '-DWITH_STATIC_LIB=ON' '-DWITH_LIBEVENT=OFF' '-DBoost_NO_BOOST_CMAKE=ON' '-DBOOST_ROOT=/build/cpp/boost_ep-prefix/src/boost_ep' '-GNinja' '/build/cpp/thrift_ep-prefix/src/thrift_ep'

  See also

    /build/cpp/thrift_ep-prefix/src/thrift_ep-stamp/thrift_ep-configure-*.log

Need to set a verbose build and see what's the matter

[nealrichardson]

Yeah I saw, didn't get back around to this today (was hoping it was a quick win). It does appear that this is the only job that tests Ubuntu 16.04--the rest are 18.04.

[wesm]

Now the image failed to build :/

[kou]

#6575 includes the fix of the failure.

[wesm]

Looks like some files in Thrift 0.13 are using CMake features introduced in CMake 3.10

CMake Error at build/cmake/FindClangTools.cmake:11 (include_guard):
  Unknown CMake command "include_guard".
Call Stack (most recent call first):
  build/cmake/StaticCodeAnalysis.cmake:1 (find_package)
  CMakeLists.txt:51 (include)


-- Configuring incomplete, errors occurred!

I'll take a look to see if this can be worked around

[wesm]

Reported upstream

https://issues.apache.org/jira/browse/THRIFT-5137

I think we can fix this by adding a patch that comments out this line

https://github.com/apache/thrift/blob/master/CMakeLists.txt#L51

[nealrichardson]

Maybe we should table this for now? There's no practical value for our upgrading the bundled version at this time, so it's probably not worth spending time hacking it.

[wesm]

Sure. Let's table it for now. Closing