ARROW-8771: [C++] Add boost/process library to build support

[liyafan82]

Some of our test source code requires the process.hpp file (and its dependent libraries). Our current build support does not include these files, causing build failures like:

fatal error: boost/process.hpp: No such file or directory

In this PR, we add required header files which are sufficient to make flight build successful.
The added header files are verified in my local machine. However, it seems the script is supposed to run from the server side, so we cannot test it.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-8771

[fsaintjacques]

@nealrichardson we might need a re-upload.

[nealrichardson]

Yes, we will. Good test of the process we (hopefully) set up before.

[nealrichardson]

I just tweaked trim-boost.sh, will need to test that this does the right thing locally, then I can update bintray and we can try all of the builds.

[nealrichardson]

Apologies if I'm slow to iterate on this; since this is a test dependency, it doesn't seem urgent, and I've got a few other things I'm juggling at the moment.

[liyafan82]

Apologies if I'm slow to iterate on this; since this is a test dependency, it doesn't seem urgent, and I've got a few other things I'm juggling at the moment.

@nealrichardson Thanks a lot for your effort, and please take your time

[nealrichardson]

@liyafan82 I rebuilt the boost bundle and uploaded to bintray. Can you re-run whichever tests you have that failed because of this before and see if they work now? If they're good now, then we can merge this.

[liyafan82]

@liyafan82 I rebuilt the boost bundle and uploaded to bintray. Can you re-run whichever tests you have that failed because of this before and see if they work now? If they're good now, then we can merge this.

@nealrichardson Thanks for your effort, I will re-run the build today.

[liyafan82]

@nealrichardson
I am sorry we still have missing files: boost/utility/enable_if.hpp.

In file included from arrow-cpp-test-debug/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/TApplicationException.h:23:0,
                 from arrow-cpp-test-debug/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/TApplicationException.cpp:20:
arrow-cpp-test-debug/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/Thrift.h:45:10: fatal error: boost/utility/enable_if.hpp: No such file or directory
 #include <boost/utility/enable_if.hpp>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

[nealrichardson]

That's odd. I wonder what's different about your build setup from the jobs we run on CI because I haven't seen that before. Do you think you could add a crossbow job that captures this build setup (is it just bundled boost and thrift, plus ARROW_FLIGHT=ON and tests on?)

FWIW this boost include has been removed in Thrift 0.13: apache/thrift@1f34504#diff-73a92ed6f7bb65d6e8f29f74ae6c94bf

So if/whenever we can upgrade to 0.13, this particular header won't ever be invoked.

[liyafan82]

That's odd. I wonder what's different about your build setup from the jobs we run on CI because I haven't seen that before. Do you think you could add a crossbow job that captures this build setup (is it just bundled boost and thrift, plus ARROW_FLIGHT=ON and tests on?)

FWIW this boost include has been removed in Thrift 0.13: apache/thrift@1f34504#diff-73a92ed6f7bb65d6e8f29f74ae6c94bf

So if/whenever we can upgrade to 0.13, this particular header won't ever be invoked.

I agree with you that a crossbow job for this build setup is extremely useful, as even if this problem is fixed, there are other problems. I will open an issue to track it.

I was using the following flags:

-DCMAKE_BUILD_TYPE=Debug -DARROW_BUILD_TESTS=ON -DARROW_BUILD_BENCHMARKS=ON -DARROW_FLIGHT=ON -DARROW_DATASET=ON -DBOOST_SOURCE=BUNDLED -DARROW_PARQUET=ON -DARROW_JNI=ON -DARROW_BUILD_EXAMPLES=ON -DCMAKE_CXX_COMPILER=.../gcc-7.2.0/bin/c++ -DCMAKE_C_COMPILER=.../gcc-7.2.0/bin/gcc

[wesm]

Could this be picked up again?

[liyafan82]

Could this be picked up again?

Maybe we can pick it up after upgrading to Thrift 0.13.

[emkornfield]

Is there a JIRA open to upgrade to thrift 0.13.0?

[liyafan82]

Is there a JIRA open to upgrade to thrift 0.13.0?

@emkornfield AFAIK, there is no such a JIRA, and I am not sure if we have a plan to upgrade to thrift 0.13.0 recently.

[nealrichardson]

Is there a JIRA open to upgrade to thrift 0.13.0?

@emkornfield AFAIK, there is no such a JIRA, and I am not sure if we have a plan to upgrade to thrift 0.13.0 recently.

https://issues.apache.org/jira/browse/ARROW-8049 is the JIRA to upgrade thrift. It looks like the obstacle we ran into before was that it requires cmake >= 3.10, and we only require 3.2. It seems we could apply a simple patch to resolve that. So it's doable, if it's worth our time to bump the version.

[wesm]

Closing for now since it doesn't seem there is an action possible right now