ARROW-7941: [Rust] [DataFusion] Add support for named columns in logical plan #6730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
requested review from
paddyhoran and
nevi-me
and removed request for
paddyhoran
|
@paddyhoran @nevi-me This is now ready for review. I'll probably start breaking this down into smaller PRs for some of the items. |
andygrove
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for unresolved columns in the logical plan so that users can add columns by name rather than index. There is a new optimizer rule that will resolve these columns and replace them with indices in the plan.
This PR also:
Arcs from the optimizer rulesLogicalPlanBuilderfor much more concise and readable code