Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-8786: [Packaging][rpm] Use bundled zstd in the CentOS 8 build #7166

Closed
wants to merge 2 commits into from

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented May 13, 2020

There was an update in the epel-release repository in the last 12 hours, since then yum/dnf is unable to find libzstd-devel.

libzstd is added to the BaseOS repository and removed from EPEL:
https://src.fedoraproject.org/rpms/zstd/c/2eaa0955a5176319f2a59294ee339cb2fff87bc5?branch=epel8

But CentOS 8 that includes zstd isn't released yet. We'll be able to revert this change with the next CentOS 8 release.

@kszucs
Copy link
Member Author

kszucs commented May 13, 2020

@github-actions crossbow submit centos-8-amd64

@github-actions
Copy link

Revision: fbdebb9

Submitted crossbow builds: ursa-labs/crossbow @ actions-250

Task Status
centos-8-amd64 Github Actions

@github-actions
Copy link

@kou
Copy link
Member

kou commented May 13, 2020

It seems that zstd is added to the BaseOS repository and removed from EPEL:
https://src.fedoraproject.org/rpms/zstd/c/2eaa0955a5176319f2a59294ee339cb2fff87bc5?branch=epel8

But CentOS 8 that includes zstd isn't released yet. We'll be able to revert this change with the next CentOS 8 release.

@kou
Copy link
Member

kou commented May 13, 2020

We also need to disable Requires: libzstd. I'll push the change.

@kou
Copy link
Member

kou commented May 13, 2020

@github-actions crossbow submit centos-8-*

@github-actions
Copy link

Revision: e4ecf59

Submitted crossbow builds: ursa-labs/crossbow @ actions-253

Task Status
centos-8-aarch64 TravisCI
centos-8-amd64 Github Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou closed this in e48a7a0 May 13, 2020
@@ -219,7 +222,9 @@ Requires: brotli
Requires: gflags
Requires: glog
%endif
%if %{have_zstd}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that.

@kszucs
Copy link
Member Author

kszucs commented May 13, 2020

Thanks Kou!

kszucs added a commit that referenced this pull request May 14, 2020
There was an update in the epel-release repository in the last 12 hours, since then yum/dnf is unable to find libzstd-devel.

libzstd is added to the BaseOS repository and removed from EPEL:
https://src.fedoraproject.org/rpms/zstd/c/2eaa0955a5176319f2a59294ee339cb2fff87bc5?branch=epel8

But CentOS 8 that includes zstd isn't released yet. We'll be able to revert this change with the next CentOS 8 release.

Closes #7166 from kszucs/ARROW-8786

Lead-authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants