Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-8962: [C++] Add explicit implementation for junk values #7286

Closed
wants to merge 1 commit into from
Closed

ARROW-8962: [C++] Add explicit implementation for junk values #7286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions cpp/src/arrow/util/value_parsing.cc
View file
Open in desktop
Expand Up @@ -47,6 +47,10 @@ struct StringToFloatConverterImpl {

static const StringToFloatConverterImpl g_string_to_float;

// Older clang versions need an explicit implementation definition.
constexpr double StringToFloatConverterImpl::main_junk_value_;
constexpr double StringToFloatConverterImpl::fallback_junk_value_;

} // namespace

bool StringToFloat(const char* s, size_t length, float* out) {
Expand Down