ARROW-8962: [C++] Add explicit implementation for junk values #7286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsaintjacques
approved these changes
May 27, 2020
bkietz
pushed a commit
to bkietz/arrow
that referenced
this pull request
May 29, 2020
When linking the tests with `clang-4.0`, I get
```
Undefined symbols for architecture x86_64:
"arrow::internal::(anonymous namespace)::StringToFloatConverterImpl::main_junk_value_", referenced from:
arrow::internal::StringToFloat(char const*, unsigned long, float*) in libarrow.a(value_parsing.cc.o)
arrow::internal::StringToFloat(char const*, unsigned long, double*) in libarrow.a(value_parsing.cc.o)
"arrow::internal::(anonymous namespace)::StringToFloatConverterImpl::fallback_junk_value_", referenced from:
arrow::internal::StringToFloat(char const*, unsigned long, float*) in libarrow.a(value_parsing.cc.o)
arrow::internal::StringToFloat(char const*, unsigned long, double*) in libarrow.a(value_parsing.cc.o)
ld: symbol(s) not found for architecture x86_64
```
These older clang versions need an explicit implementation definition.
Closes apache#7286 from xhochy/ARROW-8962
Authored-by: Uwe L. Korn <uwe.korn@quantco.com>
Signed-off-by: François Saint-Jacques <fsaintjacques@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When linking the tests with
clang-4.0, I getThese older clang versions need an explicit implementation definition.