ARROW-91: Basic Parquet read support #73

xhochy · 2016-05-08T20:53:40Z

Depends on (mainly one line fixes):

xhochy · 2016-05-08T20:55:05Z

cpp/src/arrow/parquet/reader.cc

+  NumericBuilder<ArrowType> builder(pool_, field_->type);
+  while ((values_to_read > 0) && (column_readers_.size() > 0)) {
+    // TODO: This is a lot malloc-thresing and not using the memory pool.
+    std::vector<CType> values(values_to_read);


Should or could these arrays be allocated with the MemoryPool?

On quick glance I think this it can. Take a look at PoolBuffer.

wesm · 2016-05-09T00:08:28Z

I'm going to review all the Parquet patches now, and then this one

emkornfield · 2016-05-09T04:34:55Z

cpp/src/arrow/parquet/reader.cc

+}
+
+FlatColumnReader::Impl::Impl(MemoryPool* pool, const ::parquet::ColumnDescriptor* descr,
+    std::queue<std::shared_ptr<ColumnReader>>&& column_readers)


The google style guide doesn't like r-values in method declarations. (Use rvalue references only to define move constructors and move assignment operators, or for perfect forwarding.) I think the workaround is to use std::move in the assignment list below.

wesm · 2016-05-09T05:10:21Z

Just to plant an idea that I haven't thought through fully yet -- at some point it will be important to perform IO, Parquet encoding/decoding, and Arrow serialization/deserialization concurrently. I'm not sure if there are some libraries available that can help us do this more easily (@emkornfield ?), but we should keep it in mind.

Aside I recently poked around google-concurrency-library and it didn't seem like it was a component ready to be depended on. Since our pipelines aren't that complex, building something custom with locks and condition variables will be reasonably straightforward.

emkornfield · 2016-05-10T06:24:50Z

I'm not familiar with any good library choices if the intent is to read from the file system directly.

xhochy · 2016-05-10T21:43:48Z

Incorporated all comments. We can either merge this and I make a new PR for reads with max_definition_level == 1 or I append it here when I continue work tomorrow.

wesm · 2016-05-10T21:45:37Z

I'm fine to merge. I will wait for a green build

wesm · 2016-05-10T22:56:34Z

+1, thank you

Class references are local by default and eligible for GC. We would need to convert it to global reference on library load for it to be safely used for the program lifetime.

Includes tests Author: Deepak Majeti <deepak.majeti@hpe.com> Closes apache#73 from majetideepak/PARQUET-555 and squashes the following commits: 2c53f53 [Deepak Majeti] minor fixes c7f1b24 [Deepak Majeti] addressed comment and added more tests 5b66a1f [Deepak Majeti] PARQUET-555: Dictionary page metadata handling inconsistencies

Class references are local by default and eligible for GC. We would need to convert it to global reference on library load for it to be safely used for the program lifetime.

Includes tests Author: Deepak Majeti <deepak.majeti@hpe.com> Closes apache#73 from majetideepak/PARQUET-555 and squashes the following commits: 2c53f53 [Deepak Majeti] minor fixes c7f1b24 [Deepak Majeti] addressed comment and added more tests 5b66a1f [Deepak Majeti] PARQUET-555: Dictionary page metadata handling inconsistencies Change-Id: I69248b5b3ca4aab0ee6bd0cb8511f84166b76638

Class references are local by default and eligible for GC. We would need to convert it to global reference on library load for it to be safely used for the program lifetime.

…ecord batches (apache#73)

@throws

* Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

@throws

* Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

@throws

* Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

@throws

* Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

@throws

* Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

@throws

* Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

@throws

* Flight SQL Ratification Based On Community Feedback #7 (apache#98) * Remove scope from 'hamcrest' dependency on java/pom.xml * Use flight top-level module on parent pom.xml instead of declaring each one * Avoid using getStatement inside StatementContext methods * Make StatementContext.getQuery() return String * Minor fixes on pom.xml * Move 'os-maven-plugin' to parent pom.xml * Update protobuf generation on pom.xml files * Use ClassLoader#getResource to get network.properties on TestFlightSql * Bind to any ephemeral port on TestFlightSql * Move JDBC-Arrow type default conversion from JdbcToArrowConfig to JdbcToArrowUtils * Micro-optimization: initialize ArrayList with the right size * Fix null-check on PreparedStatement#setParameters * Avoid wrapping vector into a ImmutableList and then into an ArrayList on FlightSqlExample#getTablesRoot * Remove null-check on VectorSchemaRoot on FlightSqlClient#setParameters() * Remove the need of separate cache for ResultSets * Add missing 'final' modifiers * Fix maven build from different directories (apache#114) * Add CrossReference methods to SqlProducer * Clean-up: remove boilerplate code by replacing with tools provided by Arrow Flight JDBC Adapter * Fix checkstyle and dependency management errors * Ignore broken tests * Fix broken tests for CreatePreparedStatement * Fix Schema generation not setting an unknown column type to nullable * Change FlightSqlProducer from abstract class to interface * Refactor tests due to creation of new column of primaryKey * Nit: fix checkstyle * Fix leaking connections on connection pool * [WIP] FlightSQL Ratification based on Community Comments (apache#73) * Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * Fix Minor POM Issues to allow Maven build (apache#161) * Fix minor POM Issues to allow Maven Build * Revert Flight SQL POM State * Remove unused imports Co-authored-by: Rafael Telles <rafael@telles.dev> * Ignore broken tests * Refactor tests due to creation of new column of primaryKey * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * [FlightRPC] Flight SQL POC Add extensions in the Apache Arrow project’s Arrow Flight modules to provide a standard way for clients and servers to communicate with SQL-like semantics. Do not pull to master. A message to the mailing list will accompany this and another proposal in the coming days for discussion. * Update FlightSqlProducer to conform to new design. Rename files for SQL -> Sql. Correct compilation errors in client code, but design needs to be updated. Tests do not yet compile. * Correct the dense_union type for schema return of SQL info. Correct some additional SQL -> Sql file renames. Reduce the test compilation problems (still more to do). * Additional CR changes. Note - FlightSqlExample is not functional and needs to be updated. * Add support for primary and foreign keys. * Fix broken Maven build * Add Hamcrest as a root-level dependency * Create test for GetCatalogs * Update tests for GetTables * Fix test for GetTables * Enable support for includeSchema in GetTables * Fix checkstyle and dependency management errors * Remove boilerplate code for creating a new Schema by reusing default converter from JdbcToArrowConfig#DEFAULT_JDBC_TO_ARROW_TYPE_CONVERTER * WIP: Working on fixing data consistency issue where catalog is null in some parts and "" in others * Implement FlightSqlExample's GetPrimaryKey command * WIP: Add support for GetCatalogs: GetFlightInfoCatalogs * WIP: Add support for GetCatalogs: GetStreamCatalogs * WIP: Add support for GetTableTypes: getFlightInfoTableTypes * WIP: Add support for GetTableTypes: getStreamTableTypes * Fix rebase conflicts * Minor refactor: apply DRY principle to repeated methods * Ignore broken tests * Fix broken tests for CreatePreparedStatement * Fix Schema generation not setting an unknown column type to nullable * Change FlightSqlProducer from abstract class to interface * Update FlightSql protobuf to allow nullable values as parameters for nullable fields * Start separating commandForeignKey into two new commands * Fix CheckStyle issues * Change empty string to null value * Implement CommandGetImportedKeys * Fix checkstyle violations * Minor refactor: remove unused methods * Implement FlightSqlClient.executeUpdate * Refactor the code to not use string when getting from cache * Nit: fix checkstyle * Fix conflicts between tests for creating a new statement and checking its schema * Minor refactor: remove unused fields @ FlightSqlUtils * Fix wrong StreamListener usages and multiple instances of RootAllocators * Fix checkstyle * Modify execute preparedStatement flow * Fix leaking connections on connection pool * Deal with query with parameter in the preparedStatement * Fix rebase issues with FlightSql.proto * Fix missing code on adapter/jdbc/JdbcToArrowUtils.java due to rebase issue * [WIP] FlightSQL Ratification based on Community Comments (apache#73) * Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * FlightSQL Ratification based on Community Comments (round 2) (apache#85) * Remove unused client_execution_handler from Protobuf * Update documentation on CommandGetPrimaryKeys * Update documentation on CommandGetImportedKeys and CommandGetExportedKeys * Change exception type on FlightSqlClient#executeUpdate * Add @return to FlightSqlClient#executeUpdate JavaDoc * Switch order of key_name and key_sequence on CommandGetTableKeys documentation * Update JavaDoc for FlIghtSqlClient#clearParameters * Add private constructor to FlightSqlProducer.SqlInfo * Update JavaDoc for FlIghtSqlClient#clearParameters * Fix wrong CommandGetPrimaryKeys documentation on Proto file * Fix order of key_name and key_sequence * Split CommandStatementQuery in 2 messages, one for Command and other for Ticket * Fix leaking Connections on FlightSqlExample * Remove unused variable of cache * Flight SQL Ratification Based On Community Feedback #5 (apache#91) * Delegate GetSchemaImportedKeys * Remove schema retrieval methods for catalog functions and delegate to constants * Add IPC encapsulation to Schema serialization * Fix checkstyle violations * Update javadoc for FlightSqlClient * Update documentation for FlightSql.proto Co-authored-by: Abner Eduardo Ferreira <abenaru@protonmail.ch> * Flight SQL Ratification Based On Community Feedback #6 (apache#94) * Refactored FlightSql Statement Constant names * Defined non-nullable parameters for FlightSql proto * Resolved minimal checkstyle issues * Added further documentation for catalog and schema * Refactored FlightSql proto comments to include more information * Added Field/FieldType notNullable methods * Refactored FlightSqlClient and FlightSqlExample to leverage Field notNullable method * Removed opaque query warning from FlightSql proto * Added the optional tag for the returned schema of getTables to proto * Flight SQL Ratification Based On Community Feedback #7 (apache#98) * Remove scope from 'hamcrest' dependency on java/pom.xml * Use flight top-level module on parent pom.xml instead of declaring each one * Avoid using getStatement inside StatementContext methods * Make StatementContext.getQuery() return String * Minor fixes on pom.xml * Move 'os-maven-plugin' to parent pom.xml * Update protobuf generation on pom.xml files * Use ClassLoader#getResource to get network.properties on TestFlightSql * Bind to any ephemeral port on TestFlightSql * Move JDBC-Arrow type default conversion from JdbcToArrowConfig to JdbcToArrowUtils * Micro-optimization: initialize ArrayList with the right size * Fix null-check on PreparedStatement#setParameters * Avoid wrapping vector into a ImmutableList and then into an ArrayList on FlightSqlExample#getTablesRoot * Remove null-check on VectorSchemaRoot on FlightSqlClient#setParameters() * Remove the need of separate cache for ResultSets * Add missing 'final' modifiers * Fix missing generated sources on built flight-sql jar (apache#101) * Bump protobuf version * Flight SQL Ratification Based On Community Feedback #8 (apache#113) * Change scope of arrow-memory-netty to test for flight-sql * Remove unused dependency arrow-memory-netty * Update common-pool2 and common-dbcp2 dependencies * Remove 'executions' from parent pom.xml for plugin protobuf-maven-plugin * Adjust protobuf-maven-plugin settings on pom.xml files * Move dep.protobuf.version and dep.grpc.version to top pom.xml * Remove <url> from arrow-flight's pom.xml * Fix maven build from different directories (apache#114) * Add test cases for bitshifting operations required for filtering out some SqlInfo data * Fix Schema serialization and deserialization on Flight SQL methods * [FlightSQL] Add missing method for creating bitmask from GetSqlInfo option enum (apache#148) * Add util method for creating bitmask from multiple protobuf enums for FlightSql GetSqlInfo enum * Add test cases for utility method for creating bitmask from protobuf options * Make changes regarding to reviews Co-authored-by: Rafael Telles <rafael@telles.dev> * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * WIP: Refactor SqlInfoProvider * WIP * WIP * WIP * Fix rebase issues * Restore FlightSql.proto state * Fix checkstyle * Fix rebase colateral * Restore FlightSql.proto Co-authored-by: Jose Almeida <almeidajcr90@gmail.com> Co-authored-by: Abner Eduardo Ferreira <abenaru@protonmail.ch> Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> Co-authored-by: Vinicius Fraga <62815192+vfraga@users.noreply.github.com> Co-authored-by: Ryan Nicholson <rnicholson@dremio.com> Co-authored-by: Kyle Porter <kporter@dremio.com>

Introduction This experimental PR implements Flight SQL, which formalizes SQL semantics on top of Flight. This follows designs and is a continuation of a PR started here. You can find the original proposal here, although the document has since drifted from the actual implementation. An Overview of this PR This PR adds a new module within Flight called flight-sql. flight-sql is a new Flight API that provides a standard way for clients and servers to communicate with SQL-like semantics. Like other Flight APIs, flight-sql does not provide implementation details that dictate how a client and server communicates with each other, it simply provides the SQL semantics and apply them onto the Flight API. A Walkthrough of the New Module FlightSql.proto introduces new SQL protobuf objects. FlightSqlClient introduces a new wrapper for a FlightClient that adds the Flight SQL semantics on the client side. FlightSqlProducer introduces a new FlightProducer API that adapts classic Flight requests into SQL operations. FlighSqlExample is a sample FlightSQL server implementation. Note that there are likely a few remaining items to be fleshed out, but they mostly pertain to metadata and adding to the list of formally specified metadata items. Also, this is experimental and has not formally been adopted yet. Squashed commit of the following: commit 36656e39db4451f71567cf0543a829900d91237e Author: Vinicius Fraga <62815192+vfraga@users.noreply.github.com> Date: Mon Dec 6 16:51:54 2021 -0300 Fix Subqueries SqlInfo in Protobuf and SqlInfoBuilder (#223) commit f828df65b2b28ca376e2bda8fadaef00b547fb63 Author: Rafael Telles <rafael@telles.dev> Date: Mon Dec 6 15:07:04 2021 -0300 Update FlightSql.proto docstrings commit 6ddfe7c6da71218b2308df2a862990754a8ef43c Author: Jose Almeida <53087160+jcralmeida@users.noreply.github.com> Date: Fri Dec 3 13:59:43 2021 -0300 [Java] Address Comments from ratification. (#222) * Refactor reference to schema in the database to db_schema_* * Add tableRef class and refactor call from client to use it * Remove tableRef from GetTables * Fix checkstyle issues * Set fields as final in the TableRef commit 0920e45b0efe391915ff7ef571d6c361f9be2e91 Author: Vinicius Fraga <sxvinifp@gmail.com> Date: Thu Oct 28 17:45:54 2021 -0300 Fix Maven Build after rebase with master commit d165ea7f1a4f7cff154b715924b9c2e011e158a0 Author: Vinicius Fraga <sxvinifp@gmail.com> Date: Thu Oct 28 17:31:06 2021 -0300 Increase Arrow Flight SQL Version in POM commit d5cc2bc081b68701cf1485bc4a96bca207ca0698 Author: Vinicius Fraga <sxvinifp@gmail.com> Date: Thu Oct 28 15:27:10 2021 -0300 Fix rebase issues commit dc468bc2584d88b60c2d550223cbe93ba5de1784 Author: Vinicius Fraga <sxvinifp@gmail.com> Date: Wed Oct 27 17:31:41 2021 -0300 Fix checkstyle commit b619be85134e12824f2166382d4939838fef6e10 Author: Vinicius Fraga <sxvinifp@gmail.com> Date: Wed Oct 27 15:51:23 2021 -0300 Add SqlOuterJoinSupportLevel to SqlInfoBuilder commit e7b823993bf20d17bc46ff6a9dc2fe9531843227 Author: Rafael Telles <rafael@telles.dev> Date: Mon Oct 25 15:37:11 2021 -0300 Implement SqlInfoProvider helper class (#176) * Implement SqlInfoProvider helper class * Added further javadocs to SqlInfoBuilder * Properly links the SqlInfoBuilder Javadocs to the SqlInfo one Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> commit 0c2d19d0aceb3589cc073596e4060e86dc7ce69b Author: Juscelino Junior <juscelinojunior@id.uff.br> Date: Tue Oct 19 15:03:02 2021 -0300 Fix some decos on FlightSql.proto commit 9ffd2a799f8be5434c2812373ecae82fb73bdef4 Author: Juscelino Junior <juscelinojunior@id.uff.br> Date: Tue Oct 19 14:02:03 2021 -0300 Fix supportsConvert docs on FlightSql.proto commit d5614b580a6ca4544d3ca7b487451657dd03c6bf Author: Rafael Telles <rafael@telles.dev> Date: Mon Oct 18 17:49:42 2021 -0300 Fix test failures after rebase commit afed3187ff42c08296c532bb17e5f6681afd0b4c Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Oct 18 15:56:42 2021 -0300 Remove getter and use static variable for Schemas commit eb39c6bbf264827f9e445be2c99e791319337f03 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Oct 18 15:56:10 2021 -0300 Refactor variable name from CrossReference commit 215beeb4559d841dd7dfb786bd87ceeb79a16b07 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Oct 18 15:55:18 2021 -0300 Typo on message CommandGetCrossReference commit f6f0188734a2cdc80dfbd2d090528a2b8d73eac0 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Oct 18 15:25:42 2021 -0300 Add documentation to cross reference fields on proto file commit b56ff0a833e811133d06e2424c4f4efa6eef7cac Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Oct 18 15:14:10 2021 -0300 Refactor schemas retrieval from imported, exported keys and cross-reference commit fb6026d0d006320f522302fbbafa56ac2115bcfb Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Oct 18 14:22:20 2021 -0300 Add a test to cross-reference command from flight-sql commit 250e2c014d68f9317511c58cc4e636ae41c2e247 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Oct 18 14:21:54 2021 -0300 Implement cross-reference logic on server commit 1dac11eba240ed7e369b21f0a31e50066f160e71 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Oct 18 14:21:11 2021 -0300 Add CrossReference methods to SqlProducer commit 268ca19a032c4bb1ac13b7f24a949e1bca142b4b Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Oct 18 14:19:49 2021 -0300 Add getCrossReference method to sqlClient commit 089b11dfb58c6f4090091ddd7f492b80a5476577 Author: Rafael Telles <rafael@telles.dev> Date: Mon Oct 18 12:00:42 2021 -0300 Add CommandGetCrossReference on FlightSql.proto commit c5e9865f7c395f0a361c847e02ac726f3c00f20a Author: JrJuscelino <56421957+JrJuscelino@users.noreply.github.com> Date: Mon Oct 18 15:30:17 2021 -0300 [FlightSQL] Add enum for and map vector for supportsConvert (#171) * Define enum to supports convert * Add map vector to schema template * Revert accidental changes on FlightSqlProducer * Rename SQL_JOINS_SUPPORT_LEVEL to SQL_OUTER_JOINS_SUPPORT_LEVEL * Improve SUPPORTED_CONVERSION_FUNCTIONS doc * Change * imports to singles imports on FlightSqlProducer * Revert wrong chance on FlightSqlProducer * Update java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlProducer.java Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> Co-authored-by: Vinicius Fraga <62815192+vfraga@users.noreply.github.com> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> commit a4de98dea92932065cc8297813d58e120990ccf4 Author: Rafael Telles <rafael@telles.dev> Date: Wed Oct 13 13:54:24 2021 -0300 Fix CheckStyle issues commit 30cad1bfa1b347b32ab095cdd429cfd6017f8b04 Author: Vinicius Fraga <62815192+vfraga@users.noreply.github.com> Date: Tue Oct 12 17:21:24 2021 -0300 Add Flight SQL Client Demo App to Flight SQL Package (#134) * Implemented FlightSqlClientDemoApp * Use try-with-resources * Move trw-with-resources to DemoApp only * Add back commons cli to pom commit e30bb4c2546ada6c8280494033777be9b3da8133 Author: Rafael Telles <rafael@telles.dev> Date: Tue Oct 12 15:54:57 2021 -0300 Propagate grpc version to arrow-flight/pom.xml commit 311bf36a674e0fdcf48bfc91cdc6cbf84799e043 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Oct 12 18:47:57 2021 +0000 [FlightSQL] Add missing method for creating bitmask from GetSqlInfo option enum (#148) * Add util method for creating bitmask from multiple protobuf enums for FlightSql GetSqlInfo enum * Add test cases for utility method for creating bitmask from protobuf options * Make changes regarding to reviews Co-authored-by: Rafael Telles <rafael@telles.dev> commit b315cae933048db1cc1a34d550a76b5e142a07a3 Author: Rafael Telles <rafael@telles.dev> Date: Tue Oct 12 13:49:38 2021 -0300 Remove unused imports on FlightSqlExample commit 68c1a461c7809146274e2a12e3bee67775b976b5 Author: Vinicius Fraga <sxvinifp@gmail.com> Date: Tue Oct 12 12:07:21 2021 -0300 Fix Flight SQL Dependency problems commit 8a57e9589a9e4a5c5e7c7cc875e55110cacf5605 Author: Rafael Telles <rafael@telles.dev> Date: Tue Oct 5 15:45:54 2021 -0300 Fix Schema serialization and deserialization on Flight SQL methods commit 78a6df4c48e1c36da1e2bfede5298c23992160f4 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Sep 29 14:36:57 2021 -0300 Replace uint32 fields with int64 in GetSqlInfo commit a535542f843472190d18c41aa7bc5e068327b487 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Sep 29 11:35:58 2021 -0300 Fix FlightSQL protobuf documentation commit abf57d7f3c937ea96f0066bcb28fd6247dce48bc Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Sep 27 16:55:17 2021 -0300 Replace CSV string with string list for GetSqlInfo commit d4883eaab8affc60a19f6b9c6af55383a72d4797 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Sep 27 11:43:54 2021 -0300 Rewrite some of the documentation for FlightSql.proto and redefine some types for GetSqqlInfo commit 6c676a97759f555db5a2edfd93a19b95ca9ca73e Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Fri Sep 24 16:30:22 2021 -0300 Add boolean value to dense union @ GetSqlInfo commit bbcaa9c79760c0c042750896fd6ba8f872dda634 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Fri Sep 24 15:06:35 2021 -0300 Make GetSqlInfo return uint64 bitmask as one of the dense union fields commit 926ab2a2ccc8115044b651ba18d063e40f01cdea Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Sep 22 17:50:28 2021 -0300 Add test cases for bitshifting operations required for filtering out some SqlInfo data commit 45dd21ecaf60318146beb2ab169ad74c93a21b62 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Sep 22 16:33:08 2021 -0300 Change int32 bitmask to int128 bitmask for GetSqlInfo commit 05377a8194f66f40f5764d1c7e9d8d62660b7cfd Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Sep 20 18:08:50 2021 -0300 Enrich FlightSQL documentation in protobuf definition file commit d34bf7a5ca912ede11b610c005c8d025c3408825 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Sep 20 15:01:51 2021 -0300 Add missing comment for SQL_ALL_TABLES_ARE_SELECTABLE commit 206822d13bc445ef282e05512365832424dda910 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Sep 14 23:04:59 2021 -0300 Add more data to GetSqlInfo for FlightSql.proto commit edba84d849ef12dfd60ee6abd0fe9c747da6a39a Author: Rafael Telles <rafael@telles.dev> Date: Thu Sep 16 14:05:15 2021 -0300 Remove redundant Ticket arguments from getStream* methods (#125) commit 7c50815122be74424f176adc0eb64aed14c5cb98 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Sep 15 11:23:48 2021 -0300 Redo AutoCloseable commit 4262f8b6e0909ba865ca6a5635e9c2a92d39512b Author: Rafael Telles <rafael@telles.dev> Date: Fri Sep 3 14:56:27 2021 -0300 Fix maven build from different directories (#114) commit 9d4a41eab05f53f982f532f67255252e3a9834e7 Author: Rafael Telles <rafael@telles.dev> Date: Thu Sep 2 15:06:33 2021 -0300 Flight SQL Ratification Based On Community Feedback #8 (#113) * Change scope of arrow-memory-netty to test for flight-sql * Remove unused dependency arrow-memory-netty * Update common-pool2 and common-dbcp2 dependencies * Remove 'executions' from parent pom.xml for plugin protobuf-maven-plugin * Adjust protobuf-maven-plugin settings on pom.xml files * Move dep.protobuf.version and dep.grpc.version to top pom.xml * Remove <url> from arrow-flight's pom.xml commit 46b4bce681fa91de6e1a030ebeaf227796f280e0 Author: Vinicius F <62815192+vfraga@users.noreply.github.com> Date: Thu Sep 2 11:16:44 2021 -0300 Update CommandGetPrimaryKey from FlightSql.proto (#110) Include not null on docs commit a1390f288c1149f1999548746b782d81c489f7c2 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Aug 31 15:15:54 2021 -0300 Bump protobuf version commit 3a1ab6380ce06bdb0e097991b34bec93ad232fe5 Author: Rafael Telles <rafael@telles.dev> Date: Thu Aug 26 16:43:25 2021 -0300 Fix missing generated sources on built flight-sql jar (#101) commit 1b10f60aabe928ebe58c2894959af25c37c27701 Author: Rafael Telles <rafael@telles.dev> Date: Thu Aug 26 14:16:40 2021 -0300 Allow FlightSqlClient#getSqlInfo accept SqlInfo enum arguments (#99) commit 8939ee6346d0ec11332facc45459b3949062c9fe Author: Rafael Telles <rafael@telles.dev> Date: Thu Aug 26 13:32:47 2021 -0300 Flight SQL Ratification Based On Community Feedback #7 (#98) * Remove scope from 'hamcrest' dependency on java/pom.xml * Use flight top-level module on parent pom.xml instead of declaring each one * Avoid using getStatement inside StatementContext methods * Make StatementContext.getQuery() return String * Minor fixes on pom.xml * Move 'os-maven-plugin' to parent pom.xml * Update protobuf generation on pom.xml files * Use ClassLoader#getResource to get network.properties on TestFlightSql * Bind to any ephemeral port on TestFlightSql * Move JDBC-Arrow type default conversion from JdbcToArrowConfig to JdbcToArrowUtils * Micro-optimization: initialize ArrayList with the right size * Fix null-check on PreparedStatement#setParameters * Avoid wrapping vector into a ImmutableList and then into an ArrayList on FlightSqlExample#getTablesRoot * Remove null-check on VectorSchemaRoot on FlightSqlClient#setParameters() * Remove the need of separate cache for ResultSets * Add missing 'final' modifiers commit 26482f6665305155a29a6fb8ef401c619a7b699b Author: Vinicius F <62815192+vfraga@users.noreply.github.com> Date: Wed Aug 25 16:30:38 2021 -0300 Flight SQL Ratification Based On Community Feedback #6 (#94) * Refactored FlightSql Statement Constant names * Defined non-nullable parameters for FlightSql proto * Resolved minimal checkstyle issues * Added further documentation for catalog and schema * Refactored FlightSql proto comments to include more information * Added Field/FieldType notNullable methods * Refactored FlightSqlClient and FlightSqlExample to leverage Field notNullable method * Removed opaque query warning from FlightSql proto * Added the optional tag for the returned schema of getTables to proto commit 7805e71dae21ba82ebd43d2fb36bf664d6c47de2 Author: Rafael Telles <rafael@telles.dev> Date: Wed Aug 25 11:39:51 2021 -0300 Flight SQL - Declare Protobuf enums (#93) * Declare Protobuf enums for SqlInfo and UpdateDeleteRules * Improve SqlInfo docs commit 74dc7951ed2f1c78cdf6c7ff21c56faee9d702ad Author: Rafael Telles <rafael@telles.dev> Date: Tue Aug 24 14:24:24 2021 -0300 Rearrange FlightSqlProducer#getStreamStatement arguments order commit 733cc309af791a8f1990665df600cc7026935372 Author: Vinicius Fraga <sxvinifp@gmail.com> Date: Tue Aug 24 14:20:32 2021 -0300 Added arrow-format to flight-sql pom commit 61110d9fb7616f75941fbbb4d4f59e8ef7b38097 Author: Rafael Telles <rafael@telles.dev> Date: Tue Aug 24 13:25:30 2021 -0300 Flight SQL Ratification Based On Community Feedback #5 (#91) * Delegate GetSchemaImportedKeys * Remove schema retrieval methods for catalog functions and delegate to constants * Add IPC encapsulation to Schema serialization * Fix checkstyle violations * Update javadoc for FlightSqlClient * Update documentation for FlightSql.proto Co-authored-by: Abner Eduardo Ferreira <abenaru@protonmail.ch> commit d1f0df125fda1c057bad8b293a786027254bd36f Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Aug 20 15:21:25 2021 -0300 Add argument ticket to the getStreamStatement methods commit 6dc4624ee45016c16841fbb73cb84e6f23dc199c Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Aug 20 15:21:00 2021 -0300 Add note to treat query as opaque commit 24383b8c3b7bc5b563099f260002e3a3fe144e6e Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Aug 20 15:20:33 2021 -0300 Remove unused variable of cache commit 505996c51df6ffc828cbd1541c8babb1a31a44b4 Author: Rafael Telles <rafael@telles.dev> Date: Fri Aug 20 15:02:46 2021 -0300 Fix leaking Connections on FlightSqlExample commit 6a52ebe874d6315831c13cc9d451d9d14179eed1 Author: Rafael Telles <rafael@telles.dev> Date: Thu Aug 19 16:11:25 2021 -0300 Split CommandStatementQuery in 2 messages, one for Command and other for Ticket commit 7028593148883cbc3ab383c6c1443ff9ed15f425 Author: Rafael Telles <rafael@telles.dev> Date: Thu Aug 19 14:04:26 2021 -0300 Remove unused imports on FlightSqlClient commit ca784600c2077415a327317d3fd9e3d063b23c67 Author: Rafael Telles <rafael@telles.dev> Date: Wed Aug 18 16:37:57 2021 -0300 Fix missing client_execution_handle on CommandStatementQuery (#86) commit b2ac91a3522218208d27066eb13719cfd71f5794 Author: Rafael Telles <rafael@telles.dev> Date: Wed Aug 18 14:40:11 2021 -0300 FlightSQL Ratification based on Community Comments (round 2) (#85) * Remove unused client_execution_handler from Protobuf * Update documentation on CommandGetPrimaryKeys * Update documentation on CommandGetImportedKeys and CommandGetExportedKeys * Change exception type on FlightSqlClient#executeUpdate * Add @return to FlightSqlClient#executeUpdate JavaDoc * Switch order of key_name and key_sequence on CommandGetTableKeys documentation * Update JavaDoc for FlIghtSqlClient#clearParameters * Add private constructor to FlightSqlProducer.SqlInfo * Update JavaDoc for FlIghtSqlClient#clearParameters * Fix wrong CommandGetPrimaryKeys documentation on Proto file * Fix order of key_name and key_sequence commit 0ce1e99c5deb82b144f63a42aff4da11e22863d1 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Aug 17 14:23:33 2021 -0300 [WIP] FlightSQL Ratification based on Community Comments (#73) * Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> commit 2499ee8b1c4742ff97bc058cfc608c345adb9d70 Author: Rafael Telles <rafael@telles.dev> Date: Tue Aug 10 15:15:55 2021 -0300 Fix wrong PreparedStatement cache invalidation commit 36f5fb7633446ba388ba5bf9580f21f3c521ccb4 Author: Rafael Telles <rafael@telles.dev> Date: Tue Aug 10 15:04:48 2021 -0300 Fix missing code on adapter/jdbc/JdbcToArrowUtils.java due to rebase issue commit e1622728ad72dc93e4cdde8484aa69db1509075a Author: Rafael Telles <rafael@telles.dev> Date: Tue Aug 10 14:55:02 2021 -0300 Fix rebase issues with FlightSql.proto commit 9a28e51dd90d98579f148a2b7064af17a6bfd162 Author: Rafael Telles <rafael@telles.dev> Date: Tue Aug 10 14:46:55 2021 -0300 Fix Arrow versions on new pom.xml files commit b6fb92d1e0f462412175e02ea73f4ba7e6134fec Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Aug 9 14:52:58 2021 -0300 Treat exception in executeUpdate as SQLException commit 2a3836dc1e4eae31a2e4f7bb0962f0aaeec15a3c Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Aug 6 18:01:37 2021 -0300 Refactor the setters from prepared statement and add calendar types to it commit 9840558976a1548640e7502e31725f1f295f019f Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Aug 6 15:41:07 2021 -0300 Add a method to clear the parameters from the prepared statement object commit 4c50b95ce3cff4005d32fc6a1713512168815747 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Aug 6 15:30:18 2021 -0300 Fix checkstyle at FlightSqlClient class commit 0c39ca23cd4771301db4fa39151b18fdbb410b1e Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Aug 6 15:29:40 2021 -0300 Deal with query with parameter in the preparedStatement commit 7c69c87607382a51287c8f9f2f0d4f06932a1a59 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Aug 6 15:29:02 2021 -0300 Add a new test for preparedUpdate without binding parameter commit 59c96c7459a7ad62d073b7f606de206161665642 Author: Rafael Telles <rafael@telles.dev> Date: Fri Aug 6 12:13:07 2021 -0300 Fix leaking connections on connection pool commit e14a4870f8308710de12009e24d7de932d4f71d2 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Aug 6 11:17:56 2021 -0300 Remove ignore from tests commit 26f9ec138ede01981a09e4c599d4df97160ff397 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Aug 6 11:16:35 2021 -0300 Modify execute preparedStatement flow commit 5ef5b098478dec18a54b2e659f7a04ab2c55ee4a Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Aug 6 11:15:39 2021 -0300 Create a validation for when vectorRoot is present commit 63d242525dc9bb8050ceb8ff4239cc00b65b8996 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Aug 6 11:15:04 2021 -0300 remove vectorRoot from execute and create a setter commit 9b8a0bded3829352bd586828242686c0ae8c007e Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Aug 2 13:47:25 2021 -0300 Remove unnecessary old files commit 0bca0c7630fc50643d75c803dad97a19ea4e28f6 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Aug 2 13:33:35 2021 -0300 Insert preparedStatement into a try-with-resources commit 4bdf3f3ae4b3f22197d456eabb8dc472f30dbe7a Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Aug 2 13:32:46 2021 -0300 Remove fail code used to force error commit 3264877becf38ce9dc11bcde69e544aba3ad3167 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Jul 30 16:49:40 2021 -0300 Deal with errors properly commit 827fc5bc6ab0ac9698ddac8b7c618f1307cfa503 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Jul 30 12:01:26 2021 -0300 Small refactor when getting preparedStatement due to rebase commit f56c59878be71b9f1bd4d04c2f61e0c661beb764 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Jul 30 11:49:51 2021 -0300 Add missing param to the java doc from executeUpdate Method commit d90059e7c2b0510a3bf7c322e3e62728ce5c0fc2 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Wed Jul 28 15:29:14 2021 -0300 Change preparedStatementLoadingCache to get from a ByteString commit ef23515edd3e373b6226bd5ebe725289928972f5 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Wed Jul 28 14:21:30 2021 -0300 Fix checkstyle commit e9d293620f1b53c3b836d6fa5303fd010c7dc095 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Wed Jul 28 13:56:18 2021 -0300 Fix checkstyle commit 3218db5ffa2d3e6a2e8dea10b731f44ffac8d7ca Author: Jose Almeida <almeidajcr90@gmail.com> Date: Wed Jul 28 13:55:40 2021 -0300 Add creation of Vector in a try with resources commit 27930f30617e0898e894fd629200535f1edf209f Author: Jose Almeida <almeidajcr90@gmail.com> Date: Wed Jul 28 13:41:43 2021 -0300 Refactor test from update at PreparedStatement commit 1c5b435d4fbcff87a2054dd66dddd4efe3d4363c Author: Jose Almeida <almeidajcr90@gmail.com> Date: Wed Jul 28 13:41:05 2021 -0300 Add while loop at flightStream and deal with errors commit 74e16ce1fb71bb1fbc8f58babe4486183c1dd805 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Wed Jul 28 13:39:52 2021 -0300 Nit: fix typo on putListener commit fdd35739572316214264cfdb1c68cb22718f0366 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Tue Jul 27 15:15:44 2021 -0300 add logic to executeUpdate from preparedStatement commit 524190749b2b30c77ddbda2e547edc55c193228c Author: Jose Almeida <almeidajcr90@gmail.com> Date: Tue Jul 27 15:15:03 2021 -0300 Change executeUpdate parameters commit 5aff106cda8eb657e046084056021afd265156bb Author: Jose Almeida <almeidajcr90@gmail.com> Date: Tue Jul 27 15:14:11 2021 -0300 Refactor executeUpdate test commit 41f4cb72a0b45ba649e6338d51eb372087c6336c Author: Jose Almeida <almeidajcr90@gmail.com> Date: Tue Jul 27 11:08:18 2021 -0300 Add new imports commit 455208bb4f149683cb478ce8458e6b4d299c5766 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Tue Jul 27 11:07:23 2021 -0300 initial progress at update on preparedstatment commit d939326e7fd53670e094b0c95a52a2030183278c Author: Jose Almeida <almeidajcr90@gmail.com> Date: Wed Jul 28 15:19:50 2021 -0300 Refactor the code to not use string when getting from cache commit 1aa639ef2606967c3c04370068a65118fa02677b Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Jul 26 15:12:31 2021 -0300 Refactor prepareStatement to use Cache Object commit b74ab1766649724d47256eabe9e739c2a612a670 Author: Rafael Telles <rafael@telles.dev> Date: Thu Jul 29 14:20:24 2021 -0300 Fix wrong StreamListener usages and multiple instances of RootAllocators commit 71781ecfde32dc6c170b62fa472823e201db8af8 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 26 14:44:48 2021 -0300 Minor refactor: remove unused methods commit b3af505ebf46c368976c6ae016cbab7cdc8d1ffe Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Fri Jul 23 14:09:38 2021 -0300 Fix checkstyle violations commit c8013463a427d6493ac01e51456c36221b42c79b Author: Ryan Nicholson <rnicholson@dremio.com> Date: Fri Aug 21 17:32:46 2020 -0700 [FlightRPC] Flight SQL POC Add extensions in the Apache Arrow project’s Arrow Flight modules to provide a standard way for clients and servers to communicate with SQL-like semantics. Do not pull to master. A message to the mailing list will accompany this and another proposal in the coming days for discussion. commit 5782fef9ad16c8617a7976ce4ba5377618ce034b Author: Rafael Telles <rafael@telles.dev> Date: Mon Aug 2 15:36:58 2021 -0300 Fix pom.xml for flight-sql commit d4532723f00e99b7e9021f49b17572cd7bbd3b6c Author: Rafael Telles <rafael@telles.dev> Date: Thu Jul 29 14:20:24 2021 -0300 Fix wrong StreamListener usages and multiple instances of RootAllocators commit e1305e5952d84c1fa1696b2bdc4a81aefa73c2ec Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 28 15:51:33 2021 -0300 Replace String identifier for queries with ByteString defaults commit 58cf3268e8e63fd0483eb689aa2211d3462b3e1c Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Jul 27 17:22:21 2021 -0300 Ensure connection is closed for Statement queries commit d7a87e7fd0b03efbd451d0b6682ea2882a733039 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Jul 27 13:47:06 2021 -0300 Minor refactor: remove unused fields @ FlightSqlUtils commit 9989e276992e7573ffe566b5db90037fd4d60ef2 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Jul 27 13:38:12 2021 -0300 Add UUID to Statements instead of empty identifier as to avoid conflicts between concurrent queries commit 0bde81a4d77398929298df3e9e8612f0eefb69ef Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Jul 27 13:26:15 2021 -0300 Fix conflicts between tests for creating a new statement and checking its schema commit 45e263d6adb58b95654ab9662870e5a9d859acc0 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Jul 27 11:59:19 2021 -0300 Add support for querying results upon creating statement commit c9abb32048d00cc6a838e74f2810126fc0ecaf59 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Wed Jul 28 15:20:21 2021 -0300 Nit: fix checkstyle commit c2b0d82855f8633cddd2a58722eb28ae89f0b28c Author: Jose Almeida <almeidajcr90@gmail.com> Date: Wed Jul 28 15:20:21 2021 -0300 Nit: fix checkstyle commit e4893e6663c42c301b5d9785a6b0c95f89504450 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Wed Jul 28 15:19:50 2021 -0300 Refactor the code to not use string when getting from cache commit f948e0701395ae10227b36ad497d97acb7825182 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Wed Jul 28 14:28:57 2021 -0300 Remove unnecessary extra space commit 7fb25a4dd8f8d659cc958bb8813041473336e28b Author: Jose Almeida <almeidajcr90@gmail.com> Date: Wed Jul 28 14:27:29 2021 -0300 Fix typo commit dcb045a2fbbc85acd93e374925f1742a595f050c Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 26 16:23:54 2021 -0300 Fix checkstyle violations commit 9d44a9a1f96ccd699c868a18df9bab43f9416329 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Jul 26 15:58:58 2021 -0300 Remove unused FlightSQLExample.proto commit 4fd4ed51714114671198c30c7364e288836c3202 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Jul 26 15:58:38 2021 -0300 Rename variable randomUUID commit 5a0b71d41700cc18eb547dd32f0386ed06244b7c Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Jul 26 15:14:00 2021 -0300 Remove prepareStatementCacheKey class commit 02df453fa34399a9d92fdb5ab30a8e31bf99c117 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Mon Jul 26 15:12:31 2021 -0300 Refactor prepareStatement to use Cache Object commit dc64ab5a74a2571170e45a550144c132ccecb21f Author: Rafael Telles <rafael@telles.dev> Date: Wed Jul 28 17:48:09 2021 -0300 Fix TestFlightSql.testExecuteUpdate to not hang on tests commit 9fa3520ec86ff114fc5caee1a12ecdf7974ecd61 Author: Rafael Telles <rafael@telles.dev> Date: Wed Jul 28 13:57:21 2021 -0300 Fix AutoClosables.close usage commit 73727f3ff9c1fdd5390d5f21d2dbcf33a6f961c7 Author: Rafael Telles <rafael@telles.dev> Date: Mon Jul 26 16:19:02 2021 -0300 Improve testExecuteUpdate commit b41ac7453e95b7e0f1ef0df688337786cd9a8747 Author: Rafael Telles <rafael@telles.dev> Date: Mon Jul 26 15:56:39 2021 -0300 Implement FlightSqlClient.executeUpdate commit 4587d9705e3c019f74e5cb6724c2f99c44d5e5ff Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 28 11:21:46 2021 -0300 Fix GetSqlInfo tests commit 4ad654ee59448154230e3470cc6f617998ceef39 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 28 11:07:16 2021 -0300 WIP [Broken]: Expand tests for GetSqlInfo to check required args commit 225774d5c021b44bd55f3099fa244fc30f8c672d Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 26 14:44:48 2021 -0300 Minor refactor: remove unused methods commit 5fb71003356f69afae04a4bdda7d20eabad3cd38 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 26 14:29:58 2021 -0300 Update getSqlInfo to use constant integers to represent info names commit 5c4264a44e1264997a42862c0c3918e5ed7f96d4 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 26 10:17:13 2021 -0300 Make info args nullable for FlightSqlClient#getSqlInfo commit f660b9eaef65cf094cd6debc043a76791f2491d8 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Fri Jul 23 17:40:53 2021 -0300 Update GetSqlInfo: separate each section of options by 500 commit 4a12774c707bf7ab6facc805e453d9ac292e9711 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Fri Jul 23 16:30:21 2021 -0300 Update FlightSQL GetSqlInfo: switch info from String to int for performance optimation commit 18a2c14de631dfe7fa3343395e3824a089af1888 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Fri Jul 23 14:09:38 2021 -0300 Fix checkstyle violations commit 80538369a9e6e2fc33dcaa3ed4cb94a5e975128a Author: Rafael Telles <rafael@telles.dev> Date: Fri Jul 23 13:09:16 2021 -0300 Add Imported and Exported keys schemas to Schemas class commit 1e88534fa5b0a8a9cc3651499df0f5ad051bcb9d Author: Rafael Telles <rafael@telles.dev> Date: Fri Jul 23 11:56:12 2021 -0300 Fix JavaDoc for CommandGetImportedKeys methods commit 18971c5d9589806e756577eaa5cd55d1e8e42a67 Author: Rafael Telles <rafael@telles.dev> Date: Fri Jul 23 11:49:14 2021 -0300 Implement CommandGetImportedKeys commit fb7fa006ae9b20e05a4ce00ab5e318c181bfbaba Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Jul 23 11:21:39 2021 -0300 Change assertion of list from greater than 0 to equal to 1 commit 2eb731519eacfc13a8632752d121ccf48949d1cd Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Jul 23 11:21:14 2021 -0300 add retrieval of resulSet to try-with-resources commit d885d40770cd8228b3930db7515d77edd8bfcc65 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Fri Jul 23 11:20:44 2021 -0300 Rename method getSchemaForeignKeys commit bbad34a3506a720012ebbacd667bbe67c0422dd2 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Thu Jul 22 18:08:40 2021 -0300 make method saveToVectors deal with IntVector commit 9f4fdcc8a8ed16ff170a1727094092f4e04c4e7c Author: Jose Almeida <almeidajcr90@gmail.com> Date: Thu Jul 22 18:08:15 2021 -0300 Change empty string to null value commit f0b634ab9edc1d496d7f642d69fd8def5b52f2b9 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Thu Jul 22 18:06:28 2021 -0300 Change order of the vectors of FlightSqlExample commit 4664ca77162380cea49c4972b5de126061f61ac3 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Thu Jul 22 17:49:29 2021 -0300 Refactor commands to use StringValue whenever is necessary commit 7f183c345606bc868d5cff8e125961a509e7b06d Author: Jose Almeida <almeidajcr90@gmail.com> Date: Thu Jul 22 17:48:43 2021 -0300 Refactor creation of vectors for CommangGetExportedKeys commit ef1721e80bb23f6f370b89b95bd13f03283f793e Author: Jose Almeida <almeidajcr90@gmail.com> Date: Thu Jul 22 15:52:57 2021 -0300 Fix commentary on proto and getExportedKeys method commit de9ddbd131256647c4084db2e2d50d85df7d4670 Author: Rafael Telles <rafael@telles.dev> Date: Thu Jul 22 14:41:48 2021 -0300 Fix CheckStyle issues commit bf580e83702cd1cc2e3c23b837ce062be88cecac Author: Rafael Telles <rafael@telles.dev> Date: Thu Jul 22 14:37:25 2021 -0300 Use StringValue instead of primitive string on CommandGetExportedKeys protobuf commit 664f0433423d8bc863d5123997dd1122acff7f34 Author: Rafael Telles <rafael@telles.dev> Date: Thu Jul 22 14:27:59 2021 -0300 Fix wrong usage of wasNull() commit 303e512dd26fa3d06a64069bcda42b00ad105744 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Thu Jul 22 14:08:23 2021 -0300 Deal with null values when using getInt commit d13d4e308d6767661adef11f649fc5ec51e03cdc Author: Jose Almeida <almeidajcr90@gmail.com> Date: Thu Jul 22 14:07:05 2021 -0300 Refactor variable name on proto message and methods commit c579e520fe654f3c272f9677486d92e2b1e81fb1 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Thu Jul 22 13:41:06 2021 -0300 Refactor null values and error dealing commit 03fa69e770d989c5ac42405151f5f96158f1ba84 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Thu Jul 22 13:35:30 2021 -0300 Refactor other tests to reflect the new table created for foreign keys tests commit 573b4abd5ec7a2f991942a3dfde598a45c9665ec Author: Jose Almeida <almeidajcr90@gmail.com> Date: Thu Jul 22 13:35:02 2021 -0300 create a test for getExportKeys command commit 3e16ccad6977a0379f5f6327a2f0d177919cd5d0 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Thu Jul 22 13:33:58 2021 -0300 Remove star import commit 2989fdc0aa9275e4ab6772d60bb5bf9525e9399f Author: Jose Almeida <almeidajcr90@gmail.com> Date: Thu Jul 22 13:33:14 2021 -0300 Refactor to use the new CommandGetExportedKeys commit 4e987877eaf1a7c42cf6e100fc1c40a5ec967b03 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Thu Jul 22 13:31:26 2021 -0300 Remove unnecessary parameters from ExportedKeys commit c6c7eec0a59f62dee57460be2ff5180a8cbc54bc Author: Jose Almeida <almeidajcr90@gmail.com> Date: Wed Jul 21 13:14:29 2021 -0300 Start separating commandForeignKey into two new commands commit 363f03d4f642c6fc24cdbe6827e43aad4c6c68b2 Author: Jose Almeida <almeidajcr90@gmail.com> Date: Tue Jul 20 16:16:18 2021 -0300 Refactor tests due to creation of new column of primaryKey commit 6186e4f594a54fa49b9ef3de7fed69eb562324d8 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Thu Jul 22 17:35:10 2021 -0300 Replace FlightSqlExample#buildSchema with helper methods commit 155654e7989fb16e5ca15c6501101c9d5951484b Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Thu Jul 22 16:39:23 2021 -0300 Clean up code by moving JDBC-to-Arrow conversions methods to utility class commit e37aac3928fac0c9ea4b9046caedc89cb71c594c Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Thu Jul 22 15:59:31 2021 -0300 Update FlightSql protobuf to allow nullable values as parameters for nullable fields commit fcc5837702bc77b4525d0c545c574565e9ad3966 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Thu Jul 22 15:20:12 2021 -0300 Change FlightSqlProducer from abstract class to interface commit 4cfa308c43d647186e05786c016b3bb7b311e233 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Thu Jul 22 11:43:27 2021 -0300 Fix Schema generation not setting an unknown column type to nullable commit 10d052b104d99c367f7b4aee70e311b4db00939d Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 21 20:16:47 2021 -0300 Extract calendar used by TestFlightSql commit 70e4110b27d939e3f9e1149bf0a17d6766f28129 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 21 20:07:43 2021 -0300 Minor refactor: reuse available helper methods commit d9818eabf2a10ca42e1bd79a9c9d9f1f54dd255b Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 21 19:53:51 2021 -0300 Fix broken tests for CreatePreparedStatement commit 31174a3054f6d0d3483d871fe30c4b4ef32649de Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 21 19:31:03 2021 -0300 Ignore broken tests commit 71197d1cc87162791145a237fe65b3ca5fc42836 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 21 16:04:46 2021 -0300 Minor refactor: apply DRY principle to repeated methods commit 812223d21f0a58da4e98d0c23148ab86a88a32c0 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 21 15:55:23 2021 -0300 Add support for null catalogs @ GetTables commit b11aa3daa8372dfb0ecbdf57da7cd29fb4066b50 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 21 15:51:37 2021 -0300 Fix GetCatalogs tests commit 2e145507691f1a4aae02f1ae5191b1173275fb81 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 21 15:39:43 2021 -0300 Fix checkstyle violations commit d65370e6d0c8cb6cd35eae57bf62735b84c3361f Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 21 15:37:35 2021 -0300 Extract helper method for retrieving schemas for GetSchemas commit 7db5449cc330e56e1ed46bd25729d9c7a9b12544 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 21 15:33:05 2021 -0300 Extract helper method for retrieving schemas for GetTableTypes commit 55e8df060b212cc76de576ae5581413d97ea1f4b Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 21 15:11:06 2021 -0300 Extract helper method for retrieving schemas for GetCatalogs commit 78bd66923e16362d34107b63bc054cfaba83edfd Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 21 14:58:44 2021 -0300 Extract helper method for retrieving schemas for GetTables commit dec516fe78181c06feaba73c70ff95a779fbd3c7 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Jul 20 13:57:47 2021 -0300 Fix rebase conflicts commit 28cacc898f5b0c5eac570cb511450c0c8632a70b Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Jul 20 11:18:11 2021 -0300 WIP: Working on fixing data consistency issue where catalog is null in some parts and "" in others commit 7af0a93566c608ee9c28d45f891abf3e9635b3b8 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 17:58:55 2021 -0300 Replace package-protected modifier with private commit 449d31a255e2c229c5398a4b51c4144477018f39 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 17:15:07 2021 -0300 WIP: Add support for GetSqlInfo: getSchemaSqlInfo commit 5ba01e773fdde2ee3b8422ed4385efb18034ad5e Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 15:26:44 2021 -0300 WIP: Add support for GetTableTypes: getStreamTableTypes commit fc525a74df6af0e5fdbfef556933778ec222e0ea Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 15:03:51 2021 -0300 WIP: Add support for GetTableTypes: getFlightInfoTableTypes commit 4616c066a35ce67ef83aa983532c9efe325686fa Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 14:15:44 2021 -0300 WIP: Start GetSchemas commit d036e23741d51107222730b78f067f9214c24fac Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 13:32:33 2021 -0300 WIP: Add support for GetCatalogs: GetStreamCatalogs commit 0ff6da121202d7e3c1b4ad4417088874235820cb Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 13:21:58 2021 -0300 WIP: Add support for GetCatalogs: GetFlightInfoCatalogs commit 01024de74468dc79ed98ee2434c5693a08f39139 Author: Rafael Telles <rafael@telles.dev> Date: Wed Jul 21 16:25:19 2021 -0300 Fix wrong ResultSet getter method on getStreamPrimaryKeys commit 4011d095f2918333a52f3de0e6b7154b2fb909bd Author: Rafael Telles <rafael@telles.dev> Date: Wed Jul 21 15:43:14 2021 -0300 Refactor duplicate code on getFlightInfo* methods commit c95eccf16d8f1d41b012ceada5ca277d3f576171 Author: Rafael Telles <rafael@telles.dev> Date: Wed Jul 21 15:34:38 2021 -0300 Properly handle SQLException on CommandGetPrimaryKeys commit 9cf4582cc121b0081e1afb4bd93abee15201c761 Author: Rafael Telles <rafael@telles.dev> Date: Wed Jul 21 15:34:17 2021 -0300 Avoid handling empty strings as null on CommandGetPrimaryKeys commit f484a56bd93caf84fbfe093b0be1114771e81260 Author: Rafael Telles <rafael@telles.dev> Date: Wed Jul 21 15:00:44 2021 -0300 Implement FlightSqlExample's GetPrimaryKey command commit d222c73828f8da94fac210d219ea875d0ab29393 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Jul 20 13:50:42 2021 -0300 Fix resource leaks for GetTables and CreatePreparedStatement commit b07de66476408b7dcd52be0785e1b231a6ba13c7 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Jul 20 12:36:23 2021 -0300 WIP: Working on fixing data consistency issue where catalog is null in some parts and "" in others commit ba722193a265e4ed5260c4db13b2c6a2dc4ea632 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 17:59:54 2021 -0300 Replace package-protected modifier with private commit 4a8f0f6bad2c7a3c8bfb2c919388c916d269e17b Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 17:40:33 2021 -0300 Fix checkstyle violations commit 0f6c5a6d0dc2580d1ce771c7bb30b9235cccdacb Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 15:43:14 2021 -0300 Update Javadoc for FlightSqlExample#getArrowTypeFromJdbcType commit dcdc114af8a4a1ad71df1bf3ffd78c1cd324c81b Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 15:42:23 2021 -0300 Add Javadoc for FlightSqlExample#getVectorsFromData commit 21128053fc6c7e8c43c9ebc09d32b8a5bfb5722a Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 15:39:16 2021 -0300 Auto-close resources used for GetTables commit 2239d113acb527379a7b8e1fef494398594688e8 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 15:09:16 2021 -0300 Remove unnecessary null-check for ResultSet#getInt commit 211192f304516a57c916261e45786d9c46591973 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 14:54:40 2021 -0300 Fix checkstyle violations commit ee4b6dca6798afad7ccc0d393c96ef0d622343c7 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 13:11:41 2021 -0300 Remove unneeded static imports commit 05c24b416721a81cafc9d0ad8f1abe4d097a90e1 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 13:00:33 2021 -0300 Make default JDBC converter private with getter for decoupling and safety commit 425b381b09925d7eff9251f5c8c46d9726d8b538 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 12:52:20 2021 -0300 Add TODO note to remove work from FlightSqlExample's constructor commit 6574db58763ed808a80fd25c55b378fb474b6d95 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 12:37:51 2021 -0300 Remove unnecessary comments in code commit 817d2bfb806777e56ab0f99b87b26176fcb433b5 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 12:33:03 2021 -0300 Remove boilerplate code for creating a new Schema by reusing default converter from JdbcToArrowConfig#DEFAULT_JDBC_TO_ARROW_TYPE_CONVERTER commit ea4f62079559df4e780ded431a9bdc8d533ad958 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 19 09:58:05 2021 -0300 Add precision and scale to GetTables' schema commit 91a4083caa1e86cf7b7a1dd24b3f29d2a285ad63 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Sat Jul 17 17:42:51 2021 -0300 Fix checkstyle and dependency management errors commit d37f4e6df0684137511708470d1acb0ac2b85747 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Sat Jul 17 17:35:27 2021 -0300 Fix tests for GetTables -- shows correct schema commit f810563ff5ac588c12aa328bb39fae97ab09a0bc Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Fri Jul 16 18:42:50 2021 -0300 WIP: test cases for GetTables commit d357998d9168f8d8e191ef2b536f50380d962805 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Fri Jul 16 16:51:52 2021 -0300 WIP: Fix bug where GetTables returns null if includeSchema commit 6e62f378d226fe1aa8e17576f50f91d587a768e4 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Fri Jul 16 16:40:26 2021 -0300 WIP: Fix GetTables for no schema queries commit fb1376e01ccdda215c5417a5546a24001b527e8f Author: Rafael Telles <rafael@telles.dev> Date: Fri Jul 16 15:44:05 2021 -0300 WIP: Work on getTablesRoot commit fd6c7c50eed1600cf2adf2a6453a0e06e9752ae5 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Fri Jul 16 13:28:03 2021 -0300 Update tests for GetTables -- start refactor to use proper schemas commit d5915effa29cb5970202bcd7e10fc3bfd2a76526 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Thu Jul 15 16:42:55 2021 -0300 Fix broken tests commit 992c4baae6b612b23e84bc86715be8423a2b7e49 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Thu Jul 15 16:27:52 2021 -0300 Remove unused static import commit a1fb4969ba9d391d5a06574ba6ded7cc6e9a8839 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Thu Jul 15 16:25:01 2021 -0300 Enable support for includeSchema in GetTables commit c5144f4ef357894f20081cdc50179b7fdba02b9c Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Thu Jul 15 14:53:17 2021 -0300 Remove unused fields commit 429fb4d4d8d071b9796aac4d3b8d54fab79cd173 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Thu Jul 15 14:13:57 2021 -0300 Fix checkstyle violations commit cafcd6fbd3af3b10692f1659ec74629c8a5ac556 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Thu Jul 15 14:12:16 2021 -0300 Fix broken Maven build commit 40498cc00a7dd6e4f3656b7683f76b52119a8e02 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Thu Jul 15 10:49:17 2021 -0300 Fix test for GetTables commit 89918e76fb89200eb7e4ed1d70a99712e195d382 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 14 18:15:24 2021 -0300 Update tests for GetTables commit d82990db9a3a1d22d0248be9d25dbb531097f599 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 14 17:22:41 2021 -0300 Add test for GetSchemas commit 65424b9e1d87845b5569bd54f15ff71e0ed4aaae Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 14 17:03:08 2021 -0300 Split up tests for FlightSqlExample commit 62735198376ca7f5b221f2fc0b8e915190ca8140 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 14 16:44:16 2021 -0300 Add test for GetTableTypes commit 86617615eb9cb1eb4ead0292d8aca8cb2cc09fc6 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Wed Jul 14 11:10:45 2021 -0300 Create test for GetCatalogs commit c4c9e6127a60da4ae62b7413c4cb48895b199fb0 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Jul 13 16:46:25 2021 -0300 Update FlightSqlExample for code reusability commit 44f7ed56da8c97bd4a6daae55e0845c57f798299 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Jul 13 13:48:50 2021 -0300 Add TODOs for future refactor commit 6665829bca908a890dce23c89ee885638cd42171 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Jul 13 12:04:54 2021 -0300 Start re-implementation of tests for CommandGetTables commit a4a5863f8b726a7790e5bb9cc4230f1597faa273 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Jul 13 10:02:55 2021 -0300 Update Javadoc; warn about premature closing of resources commit 41fe35db750b9b4e3a430ba43e8563f917a1c515 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Tue Jul 13 09:51:41 2021 -0300 Fix bad assertion in tests for simple prepared statement commit 6b62c13a9a917321534616b9d8d623c51da9d02f Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 12 20:12:05 2021 -0300 Update tests commit 7bcab261fe81e177ecb7e86c7817c6dc5147ffff Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 12 18:21:55 2021 -0300 Clean-up: remove boilerplate code by replacing with tools provided by Arrow Flight JDBC Adapter commit 9f28ddda170e8564db60d701390079f9e95c43b9 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 12 19:43:50 2021 -0300 Remove unnecessary overridden method from FlightSqlExample commit 52ebd2d2bbd9b316ba3df5c891be95ed19ba2a95 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 12 20:07:55 2021 -0300 Replace static initializer block with @BeforeClass in tests commit 139f62b0cc0ba9a85e3e7de1fafcfbbb5a3a5216 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 12 19:43:50 2021 -0300 Remove unnecessary overridden method from FlightSqlExample commit 7cce16a88d9586b58cf0aa2f777c30ae77bcfba8 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 12 19:41:18 2021 -0300 Remove unnecessary singletonList in tests commit d4d0b58fd28e0282a885e588bbc4b39ab50826ad Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 12 19:37:28 2021 -0300 Replace me.alexpanov:free-port-finder with org.codehaus.mojo:build-helper-maven-plugin:reserve-network-port commit f39e3726ebb8d761f02229444aa4ebca4be70127 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 12 18:44:49 2021 -0300 Add Hamcrest as a root-level dependency commit cc7cc3d4402c082a26d2e71c23cde767e07e88c2 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Mon Jul 12 15:56:07 2021 -0300 Fix code style issues such as excessive usage of static imports commit d0f8a97b03142b55a446fda59e70f23325421cd3 Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Fri Jul 9 18:22:35 2021 -0300 Clear broken code for readability -- this will be useful for fixing things faster commit 1619811f37b3c26eb5b7af2007b9afea19839aed Author: Abner Eduardo Ferreira <abenaru@protonmail.ch> Date: Fri Jul 9 17:38:48 2021 -0300 Fix broken Maven build commit f813b5fb019ad21c345aefff876d936230d24a9b Author: Kyle Porter <kporter@dremio.com> Date: Wed Jul 7 10:06:34 2021 -0700 Add support for primary and foreign keys. commit 090631fe22eb251a82e8e271cd3d3a073a48d6bb Author: Kyle Porter <kporter@dremio.com> Date: Tue Jul 6 16:28:54 2021 -0700 Additional CR changes. Note - FlightSqlExample is not functional and needs to be updated. commit aacaee029b93d5ad618b29dec78ae94a1f8b9376 Author: Kyle Porter <kporter@dremio.com> Date: Mon Jul 5 17:12:44 2021 -0700 Correct the dense_union type for schema return of SQL info. Correct some additional SQL -> Sql file renames. Reduce the test compilation problems (still more to do). commit 3aab4a7ff026c1e6ab9b5d6a0d0878412f1a270d Author: Kyle Porter <kporter@dremio.com> Date: Mon Jul 5 15:25:33 2021 -0700 Update FlightSqlProducer to conform to new design. Rename files for SQL -> Sql. Correct compilation errors in client code, but design needs to be updated. Tests do not yet compile. commit 54e6dfeb70acf892dec0c6bbe49850db14c4818b Author: tifflhl <tiffanylamhl@gmail.com> Date: Thu Jan 21 18:15:59 2021 -0800 Address code review comments (1) - Address code review comments from https://github.com/ryannicholson/arrow/pull/2 commit 4edf6b7e21ea8fb5cf14d48b8a88bf93b90b7ce1 Author: Ryan Nicholson <rnicholson@dremio.com> Date: Wed Sep 2 08:32:31 2020 -0700 Rename "getSQLCapabilities" to "getSQLInfo" in FlightSQLProducer commit ec981a298cee568ae27345295ec49d8109d2a37c Author: Ryan Nicholson <rnicholson@dremio.com> Date: Tue Sep 1 17:44:18 2020 -0700 Alter GetSQLCapabilies to GetSQLInfo pattern Alter GetSQLCapabilities to model after Hive Thrift's TCLIService. commit 4d4082d172162c68dee2a098d7b229e93dd9c147 Author: Ryan Nicholson <rnicholson@dremio.com> Date: Tue Sep 1 09:45:38 2020 -0700 FlightSQL.proto formatting feedback Update with initial formatting/naming feedback and add ResultsOrder enum. commit 7409fb41bdafff93ade4e83603d697315409e0fa Author: Ryan Nicholson <rnicholson@dremio.com> Date: Fri Aug 21 17:32:46 2020 -0700 [FlightRPC] Flight SQL POC Add extensions in the Apache Arrow project’s Arrow Flight modules to provide a standard way for clients and servers to communicate with SQL-like semantics. Do not pull to master. A message to the mailing list will accompany this and another proposal in the coming days for discussion.

…ache#73)

…ache#73) (apache#74) Co-authored-by: Hongze Zhang <hongze.zhang@intel.com>

@throws

* Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

@throws

* Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

@throws

* Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

@throws

* Flight SQL Ratification Based On Community Feedback #7 (apache#98) * Remove scope from 'hamcrest' dependency on java/pom.xml * Use flight top-level module on parent pom.xml instead of declaring each one * Avoid using getStatement inside StatementContext methods * Make StatementContext.getQuery() return String * Minor fixes on pom.xml * Move 'os-maven-plugin' to parent pom.xml * Update protobuf generation on pom.xml files * Use ClassLoader#getResource to get network.properties on TestFlightSql * Bind to any ephemeral port on TestFlightSql * Move JDBC-Arrow type default conversion from JdbcToArrowConfig to JdbcToArrowUtils * Micro-optimization: initialize ArrayList with the right size * Fix null-check on PreparedStatement#setParameters * Avoid wrapping vector into a ImmutableList and then into an ArrayList on FlightSqlExample#getTablesRoot * Remove null-check on VectorSchemaRoot on FlightSqlClient#setParameters() * Remove the need of separate cache for ResultSets * Add missing 'final' modifiers * Fix maven build from different directories (apache#114) * Add CrossReference methods to SqlProducer * Clean-up: remove boilerplate code by replacing with tools provided by Arrow Flight JDBC Adapter * Fix checkstyle and dependency management errors * Ignore broken tests * Fix broken tests for CreatePreparedStatement * Fix Schema generation not setting an unknown column type to nullable * Change FlightSqlProducer from abstract class to interface * Refactor tests due to creation of new column of primaryKey * Nit: fix checkstyle * Fix leaking connections on connection pool * [WIP] FlightSQL Ratification based on Community Comments (apache#73) * Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * Fix Minor POM Issues to allow Maven build (apache#161) * Fix minor POM Issues to allow Maven Build * Revert Flight SQL POM State * Remove unused imports Co-authored-by: Rafael Telles <rafael@telles.dev> * Ignore broken tests * Refactor tests due to creation of new column of primaryKey * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * [FlightRPC] Flight SQL POC Add extensions in the Apache Arrow project’s Arrow Flight modules to provide a standard way for clients and servers to communicate with SQL-like semantics. Do not pull to master. A message to the mailing list will accompany this and another proposal in the coming days for discussion. * Update FlightSqlProducer to conform to new design. Rename files for SQL -> Sql. Correct compilation errors in client code, but design needs to be updated. Tests do not yet compile. * Correct the dense_union type for schema return of SQL info. Correct some additional SQL -> Sql file renames. Reduce the test compilation problems (still more to do). * Additional CR changes. Note - FlightSqlExample is not functional and needs to be updated. * Add support for primary and foreign keys. * Fix broken Maven build * Add Hamcrest as a root-level dependency * Create test for GetCatalogs * Update tests for GetTables * Fix test for GetTables * Enable support for includeSchema in GetTables * Fix checkstyle and dependency management errors * Remove boilerplate code for creating a new Schema by reusing default converter from JdbcToArrowConfig#DEFAULT_JDBC_TO_ARROW_TYPE_CONVERTER * WIP: Working on fixing data consistency issue where catalog is null in some parts and "" in others * Implement FlightSqlExample's GetPrimaryKey command * WIP: Add support for GetCatalogs: GetFlightInfoCatalogs * WIP: Add support for GetCatalogs: GetStreamCatalogs * WIP: Add support for GetTableTypes: getFlightInfoTableTypes * WIP: Add support for GetTableTypes: getStreamTableTypes * Fix rebase conflicts * Minor refactor: apply DRY principle to repeated methods * Ignore broken tests * Fix broken tests for CreatePreparedStatement * Fix Schema generation not setting an unknown column type to nullable * Change FlightSqlProducer from abstract class to interface * Update FlightSql protobuf to allow nullable values as parameters for nullable fields * Start separating commandForeignKey into two new commands * Fix CheckStyle issues * Change empty string to null value * Implement CommandGetImportedKeys * Fix checkstyle violations * Minor refactor: remove unused methods * Implement FlightSqlClient.executeUpdate * Refactor the code to not use string when getting from cache * Nit: fix checkstyle * Fix conflicts between tests for creating a new statement and checking its schema * Minor refactor: remove unused fields @ FlightSqlUtils * Fix wrong StreamListener usages and multiple instances of RootAllocators * Fix checkstyle * Modify execute preparedStatement flow * Fix leaking connections on connection pool * Deal with query with parameter in the preparedStatement * Fix rebase issues with FlightSql.proto * Fix missing code on adapter/jdbc/JdbcToArrowUtils.java due to rebase issue * [WIP] FlightSQL Ratification based on Community Comments (apache#73) * Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * FlightSQL Ratification based on Community Comments (round 2) (apache#85) * Remove unused client_execution_handler from Protobuf * Update documentation on CommandGetPrimaryKeys * Update documentation on CommandGetImportedKeys and CommandGetExportedKeys * Change exception type on FlightSqlClient#executeUpdate * Add @return to FlightSqlClient#executeUpdate JavaDoc * Switch order of key_name and key_sequence on CommandGetTableKeys documentation * Update JavaDoc for FlIghtSqlClient#clearParameters * Add private constructor to FlightSqlProducer.SqlInfo * Update JavaDoc for FlIghtSqlClient#clearParameters * Fix wrong CommandGetPrimaryKeys documentation on Proto file * Fix order of key_name and key_sequence * Split CommandStatementQuery in 2 messages, one for Command and other for Ticket * Fix leaking Connections on FlightSqlExample * Remove unused variable of cache * Flight SQL Ratification Based On Community Feedback #5 (apache#91) * Delegate GetSchemaImportedKeys * Remove schema retrieval methods for catalog functions and delegate to constants * Add IPC encapsulation to Schema serialization * Fix checkstyle violations * Update javadoc for FlightSqlClient * Update documentation for FlightSql.proto Co-authored-by: Abner Eduardo Ferreira <abenaru@protonmail.ch> * Flight SQL Ratification Based On Community Feedback #6 (apache#94) * Refactored FlightSql Statement Constant names * Defined non-nullable parameters for FlightSql proto * Resolved minimal checkstyle issues * Added further documentation for catalog and schema * Refactored FlightSql proto comments to include more information * Added Field/FieldType notNullable methods * Refactored FlightSqlClient and FlightSqlExample to leverage Field notNullable method * Removed opaque query warning from FlightSql proto * Added the optional tag for the returned schema of getTables to proto * Flight SQL Ratification Based On Community Feedback #7 (apache#98) * Remove scope from 'hamcrest' dependency on java/pom.xml * Use flight top-level module on parent pom.xml instead of declaring each one * Avoid using getStatement inside StatementContext methods * Make StatementContext.getQuery() return String * Minor fixes on pom.xml * Move 'os-maven-plugin' to parent pom.xml * Update protobuf generation on pom.xml files * Use ClassLoader#getResource to get network.properties on TestFlightSql * Bind to any ephemeral port on TestFlightSql * Move JDBC-Arrow type default conversion from JdbcToArrowConfig to JdbcToArrowUtils * Micro-optimization: initialize ArrayList with the right size * Fix null-check on PreparedStatement#setParameters * Avoid wrapping vector into a ImmutableList and then into an ArrayList on FlightSqlExample#getTablesRoot * Remove null-check on VectorSchemaRoot on FlightSqlClient#setParameters() * Remove the need of separate cache for ResultSets * Add missing 'final' modifiers * Fix missing generated sources on built flight-sql jar (apache#101) * Bump protobuf version * Flight SQL Ratification Based On Community Feedback #8 (apache#113) * Change scope of arrow-memory-netty to test for flight-sql * Remove unused dependency arrow-memory-netty * Update common-pool2 and common-dbcp2 dependencies * Remove 'executions' from parent pom.xml for plugin protobuf-maven-plugin * Adjust protobuf-maven-plugin settings on pom.xml files * Move dep.protobuf.version and dep.grpc.version to top pom.xml * Remove <url> from arrow-flight's pom.xml * Fix maven build from different directories (apache#114) * Add test cases for bitshifting operations required for filtering out some SqlInfo data * Fix Schema serialization and deserialization on Flight SQL methods * [FlightSQL] Add missing method for creating bitmask from GetSqlInfo option enum (apache#148) * Add util method for creating bitmask from multiple protobuf enums for FlightSql GetSqlInfo enum * Add test cases for utility method for creating bitmask from protobuf options * Make changes regarding to reviews Co-authored-by: Rafael Telles <rafael@telles.dev> * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * WIP: Refactor SqlInfoProvider * WIP * WIP * WIP * Fix rebase issues * Restore FlightSql.proto state * Fix checkstyle * Fix rebase colateral * Restore FlightSql.proto Co-authored-by: Jose Almeida <almeidajcr90@gmail.com> Co-authored-by: Abner Eduardo Ferreira <abenaru@protonmail.ch> Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> Co-authored-by: Vinicius Fraga <62815192+vfraga@users.noreply.github.com> Co-authored-by: Ryan Nicholson <rnicholson@dremio.com> Co-authored-by: Kyle Porter <kporter@dremio.com>

…ache#73)

@throws

* Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

@throws

* Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

@throws

* Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

@throws

* Flight SQL Ratification Based On Community Feedback #7 (apache#98) * Remove scope from 'hamcrest' dependency on java/pom.xml * Use flight top-level module on parent pom.xml instead of declaring each one * Avoid using getStatement inside StatementContext methods * Make StatementContext.getQuery() return String * Minor fixes on pom.xml * Move 'os-maven-plugin' to parent pom.xml * Update protobuf generation on pom.xml files * Use ClassLoader#getResource to get network.properties on TestFlightSql * Bind to any ephemeral port on TestFlightSql * Move JDBC-Arrow type default conversion from JdbcToArrowConfig to JdbcToArrowUtils * Micro-optimization: initialize ArrayList with the right size * Fix null-check on PreparedStatement#setParameters * Avoid wrapping vector into a ImmutableList and then into an ArrayList on FlightSqlExample#getTablesRoot * Remove null-check on VectorSchemaRoot on FlightSqlClient#setParameters() * Remove the need of separate cache for ResultSets * Add missing 'final' modifiers * Fix maven build from different directories (apache#114) * Add CrossReference methods to SqlProducer * Clean-up: remove boilerplate code by replacing with tools provided by Arrow Flight JDBC Adapter * Fix checkstyle and dependency management errors * Ignore broken tests * Fix broken tests for CreatePreparedStatement * Fix Schema generation not setting an unknown column type to nullable * Change FlightSqlProducer from abstract class to interface * Refactor tests due to creation of new column of primaryKey * Nit: fix checkstyle * Fix leaking connections on connection pool * [WIP] FlightSQL Ratification based on Community Comments (apache#73) * Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * Fix Minor POM Issues to allow Maven build (apache#161) * Fix minor POM Issues to allow Maven Build * Revert Flight SQL POM State * Remove unused imports Co-authored-by: Rafael Telles <rafael@telles.dev> * Ignore broken tests * Refactor tests due to creation of new column of primaryKey * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * [FlightRPC] Flight SQL POC Add extensions in the Apache Arrow project’s Arrow Flight modules to provide a standard way for clients and servers to communicate with SQL-like semantics. Do not pull to master. A message to the mailing list will accompany this and another proposal in the coming days for discussion. * Update FlightSqlProducer to conform to new design. Rename files for SQL -> Sql. Correct compilation errors in client code, but design needs to be updated. Tests do not yet compile. * Correct the dense_union type for schema return of SQL info. Correct some additional SQL -> Sql file renames. Reduce the test compilation problems (still more to do). * Additional CR changes. Note - FlightSqlExample is not functional and needs to be updated. * Add support for primary and foreign keys. * Fix broken Maven build * Add Hamcrest as a root-level dependency * Create test for GetCatalogs * Update tests for GetTables * Fix test for GetTables * Enable support for includeSchema in GetTables * Fix checkstyle and dependency management errors * Remove boilerplate code for creating a new Schema by reusing default converter from JdbcToArrowConfig#DEFAULT_JDBC_TO_ARROW_TYPE_CONVERTER * WIP: Working on fixing data consistency issue where catalog is null in some parts and "" in others * Implement FlightSqlExample's GetPrimaryKey command * WIP: Add support for GetCatalogs: GetFlightInfoCatalogs * WIP: Add support for GetCatalogs: GetStreamCatalogs * WIP: Add support for GetTableTypes: getFlightInfoTableTypes * WIP: Add support for GetTableTypes: getStreamTableTypes * Fix rebase conflicts * Minor refactor: apply DRY principle to repeated methods * Ignore broken tests * Fix broken tests for CreatePreparedStatement * Fix Schema generation not setting an unknown column type to nullable * Change FlightSqlProducer from abstract class to interface * Update FlightSql protobuf to allow nullable values as parameters for nullable fields * Start separating commandForeignKey into two new commands * Fix CheckStyle issues * Change empty string to null value * Implement CommandGetImportedKeys * Fix checkstyle violations * Minor refactor: remove unused methods * Implement FlightSqlClient.executeUpdate * Refactor the code to not use string when getting from cache * Nit: fix checkstyle * Fix conflicts between tests for creating a new statement and checking its schema * Minor refactor: remove unused fields @ FlightSqlUtils * Fix wrong StreamListener usages and multiple instances of RootAllocators * Fix checkstyle * Modify execute preparedStatement flow * Fix leaking connections on connection pool * Deal with query with parameter in the preparedStatement * Fix rebase issues with FlightSql.proto * Fix missing code on adapter/jdbc/JdbcToArrowUtils.java due to rebase issue * [WIP] FlightSQL Ratification based on Community Comments (apache#73) * Move FlightSql examples to their own subpackage * Fix checkstyle issues * fix: change Status use to CallStatus * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking * Replace Guava's Preconditions with the ones provided by Apache * Fix typo in FlightSql.proto * Fix ordering of schema for FlightSql.proto * Explain why reserved range of IDs for GetSqlInfo is not entirely in use * Add comment to CommandGetTables to explain the encoding of table_schema * Remove redundat information on schemas * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description * Replace int32 with uint32 for GetSqlInfo name representation * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message * add comment to FlightSql.proto to update_rule and delete_rule * Replace inconsistent exception handling with CallStatus predetermined exceptions * correct comment to CreatePreparedStatement on FlightSql.proto * Remove unused dependencies * fix: change Status use to CallStatus on FlightSqlProducer * Changed from if not null check to Objects requireNonNull on Flight SQL Client * Remove Nullable annotation * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example * Add CallOptions to every RPC call by the client * Fix Maven dependency problems and checkstyle violations * Replace generic Collections with Lists when order matters in an RPC call * Fix Javadoc for FlightSqlClient * Add description to StatusRuntimeExceptions * Add descriptions to Exceptions * Correct update_rule and delete_rule description on FlighSql.proto * Verify wheter Root is empty before sending request to server * Add call options to PreparedStatement * Replace constant checking of whether client is open with #checkOpen * Add CallOptions to #close for PreparedStatement * Refactor PreparedStatement usages of CallOptions * Fix broken tests * Fix FlightSql.proto documentation * Update documentation for format/FlightSql.proto Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * Fix checkstyle violations * Require non null tables for GetExportedKeys and GetImportedKeys * Not storing CallOptions in PreparedStatement * Update documentation comments for protobuf * Replace IntVector for UInt1Vector for delete_rule and update_rule * Fix protobuf for FlightSQL * Fix bug with empty metadata * Update update_rule and delete_rule documentation on proto * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules * Use MessageOptions instead of FieldOptions on proto * Add missing JavaDoc about 'options' parameter * Fix CommandGetSqlInfo documentation * Add @throws to FlightSqlClient#checkOpen JavaDoc Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> * FlightSQL Ratification based on Community Comments (round 2) (apache#85) * Remove unused client_execution_handler from Protobuf * Update documentation on CommandGetPrimaryKeys * Update documentation on CommandGetImportedKeys and CommandGetExportedKeys * Change exception type on FlightSqlClient#executeUpdate * Add @return to FlightSqlClient#executeUpdate JavaDoc * Switch order of key_name and key_sequence on CommandGetTableKeys documentation * Update JavaDoc for FlIghtSqlClient#clearParameters * Add private constructor to FlightSqlProducer.SqlInfo * Update JavaDoc for FlIghtSqlClient#clearParameters * Fix wrong CommandGetPrimaryKeys documentation on Proto file * Fix order of key_name and key_sequence * Split CommandStatementQuery in 2 messages, one for Command and other for Ticket * Fix leaking Connections on FlightSqlExample * Remove unused variable of cache * Flight SQL Ratification Based On Community Feedback #5 (apache#91) * Delegate GetSchemaImportedKeys * Remove schema retrieval methods for catalog functions and delegate to constants * Add IPC encapsulation to Schema serialization * Fix checkstyle violations * Update javadoc for FlightSqlClient * Update documentation for FlightSql.proto Co-authored-by: Abner Eduardo Ferreira <abenaru@protonmail.ch> * Flight SQL Ratification Based On Community Feedback #6 (apache#94) * Refactored FlightSql Statement Constant names * Defined non-nullable parameters for FlightSql proto * Resolved minimal checkstyle issues * Added further documentation for catalog and schema * Refactored FlightSql proto comments to include more information * Added Field/FieldType notNullable methods * Refactored FlightSqlClient and FlightSqlExample to leverage Field notNullable method * Removed opaque query warning from FlightSql proto * Added the optional tag for the returned schema of getTables to proto * Flight SQL Ratification Based On Community Feedback #7 (apache#98) * Remove scope from 'hamcrest' dependency on java/pom.xml * Use flight top-level module on parent pom.xml instead of declaring each one * Avoid using getStatement inside StatementContext methods * Make StatementContext.getQuery() return String * Minor fixes on pom.xml * Move 'os-maven-plugin' to parent pom.xml * Update protobuf generation on pom.xml files * Use ClassLoader#getResource to get network.properties on TestFlightSql * Bind to any ephemeral port on TestFlightSql * Move JDBC-Arrow type default conversion from JdbcToArrowConfig to JdbcToArrowUtils * Micro-optimization: initialize ArrayList with the right size * Fix null-check on PreparedStatement#setParameters * Avoid wrapping vector into a ImmutableList and then into an ArrayList on FlightSqlExample#getTablesRoot * Remove null-check on VectorSchemaRoot on FlightSqlClient#setParameters() * Remove the need of separate cache for ResultSets * Add missing 'final' modifiers * Fix missing generated sources on built flight-sql jar (apache#101) * Bump protobuf version * Flight SQL Ratification Based On Community Feedback #8 (apache#113) * Change scope of arrow-memory-netty to test for flight-sql * Remove unused dependency arrow-memory-netty * Update common-pool2 and common-dbcp2 dependencies * Remove 'executions' from parent pom.xml for plugin protobuf-maven-plugin * Adjust protobuf-maven-plugin settings on pom.xml files * Move dep.protobuf.version and dep.grpc.version to top pom.xml * Remove <url> from arrow-flight's pom.xml * Fix maven build from different directories (apache#114) * Add test cases for bitshifting operations required for filtering out some SqlInfo data * Fix Schema serialization and deserialization on Flight SQL methods * [FlightSQL] Add missing method for creating bitmask from GetSqlInfo option enum (apache#148) * Add util method for creating bitmask from multiple protobuf enums for FlightSql GetSqlInfo enum * Add test cases for utility method for creating bitmask from protobuf options * Make changes regarding to reviews Co-authored-by: Rafael Telles <rafael@telles.dev> * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * Create a module for keeping all Arrow Flight-related submodules * Fix checkstyle violations in Arrow Flight JDBC Driver * WIP: Refactor SqlInfoProvider * WIP * WIP * WIP * Fix rebase issues * Restore FlightSql.proto state * Fix checkstyle * Fix rebase colateral * Restore FlightSql.proto Co-authored-by: Jose Almeida <almeidajcr90@gmail.com> Co-authored-by: Abner Eduardo Ferreira <abenaru@protonmail.ch> Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com> Co-authored-by: Vinicius Fraga <62815192+vfraga@users.noreply.github.com> Co-authored-by: Ryan Nicholson <rnicholson@dremio.com> Co-authored-by: Kyle Porter <kporter@dremio.com>

…ache#73)

wesm and others added 2 commits May 8, 2016 16:36

Public API draft

d9940d8

ARROW-91: Basic Parquet read support

8d2db22

xhochy reviewed May 8, 2016
View reviewed changes

emkornfield reviewed May 9, 2016
View reviewed changes

xhochy added 3 commits May 10, 2016 23:33

Incorporate review comments

5fa1026

Assert that no exception was thrown

47441a1

Mark single argument constructor as explicit

7579fed

asfgit closed this in 4bd13b8 May 10, 2016

xhochy deleted the arrow-91 branch March 7, 2017 16:16

xuechendi pushed a commit to xuechendi/arrow that referenced this pull request Aug 4, 2020

Datasets Java API: Support readning parquet into dictionary-encoded r…

c1f2ec7

…ecord batches (apache#73)

zhouyuan pushed a commit to zhouyuan/arrow that referenced this pull request Jan 9, 2022

Fix wrong Tell() result from BufferedOutputStream in an edge case (ap…

979b9af

…ache#73)

zhztheplayer added a commit to zhztheplayer/arrow-1 that referenced this pull request Jan 10, 2022

Fix wrong Tell() result from BufferedOutputStream in an edge case (ap…

8081dde

…ache#73)

zhouyuan added a commit to zhouyuan/arrow that referenced this pull request Jan 10, 2022

Fix wrong Tell() result from BufferedOutputStream in an edge case (ap…

21698d7

…ache#73) (apache#74) Co-authored-by: Hongze Zhang <hongze.zhang@intel.com>

zhztheplayer added a commit to zhztheplayer/arrow-1 that referenced this pull request Feb 8, 2022

Fix wrong Tell() result from BufferedOutputStream in an edge case (ap…

31917cc

…ache#73)

zhztheplayer added a commit to zhztheplayer/arrow-1 that referenced this pull request Mar 3, 2022

Fix wrong Tell() result from BufferedOutputStream in an edge case (ap…

f53137e

…ache#73)

rui-mo pushed a commit to rui-mo/arrow-1 that referenced this pull request Mar 23, 2022

Fix wrong Tell() result from BufferedOutputStream in an edge case (ap…

069f27a

…ache#73)

zhouyuan pushed a commit to zhouyuan/arrow that referenced this pull request Apr 26, 2022

Fix wrong Tell() result from BufferedOutputStream in an edge case (ap…

adfb9eb

…ache#73)

zhztheplayer added a commit to zhztheplayer/arrow-1 that referenced this pull request May 27, 2022

Fix wrong Tell() result from BufferedOutputStream in an edge case (ap…

1860dd1

…ache#73)

rui-mo pushed a commit to rui-mo/arrow-1 that referenced this pull request May 27, 2022

Fix wrong Tell() result from BufferedOutputStream in an edge case (ap…

ca7984a

…ache#73)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARROW-91: Basic Parquet read support #73

ARROW-91: Basic Parquet read support #73

xhochy commented May 8, 2016 •

edited

xhochy May 8, 2016

emkornfield May 9, 2016 •

edited

wesm commented May 9, 2016

emkornfield May 9, 2016

wesm commented May 9, 2016

emkornfield commented May 10, 2016

xhochy commented May 10, 2016

wesm commented May 10, 2016

wesm commented May 10, 2016

ARROW-91: Basic Parquet read support #73

ARROW-91: Basic Parquet read support #73

Conversation

xhochy commented May 8, 2016 • edited

xhochy May 8, 2016

Choose a reason for hiding this comment

emkornfield May 9, 2016 • edited

Choose a reason for hiding this comment

wesm commented May 9, 2016

emkornfield May 9, 2016

Choose a reason for hiding this comment

wesm commented May 9, 2016

emkornfield commented May 10, 2016

xhochy commented May 10, 2016

wesm commented May 10, 2016

wesm commented May 10, 2016

xhochy commented May 8, 2016 •

edited

emkornfield May 9, 2016 •

edited