This repository has been archived by the owner on May 10, 2024. It is now read-only.
PARQUET-603: Implement missing information in schema descriptor #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +19,7 @@ | |||
| install(FILES | |||
| page.h | |||
| levels.h | |||
| properties.h | |||
There was a problem hiding this comment.
I missed this in the previous patch
3 tasks
| @@ -99,14 +99,18 @@ class SchemaDescriptor { | |||
|
|
|||
| const schema::NodePtr& schema() const { return schema_; } | |||
|
|
|||
| const schema::GroupNode* group() const { return group_; } | |||
|
|
|||
| const schema::NodePtr& base(int i) const; | |||
There was a problem hiding this comment.
Add a comment explaining this method -- I'm wondering what might be a more descriptive name, like GetLeafRoot or something
There was a problem hiding this comment.
How does GetColumnRoot sound ?
added 3 commits
May 9, 2016 00:03
|
+1, thank you! |
asfgit
pushed a commit
to apache/arrow
that referenced
this pull request
May 10, 2016
Depends on (mainly one line fixes): - [x] apache/parquet-cpp#99 - [x] apache/parquet-cpp#98 - [x] apache/parquet-cpp#97 Author: Uwe L. Korn <uwelk@xhochy.com> Author: Wes McKinney <wesm@apache.org> Closes #73 from xhochy/arrow-91 and squashes the following commits: 7579fed [Uwe L. Korn] Mark single argument constructor as explicit 47441a1 [Uwe L. Korn] Assert that no exception was thrown 5fa1026 [Uwe L. Korn] Incorporate review comments 8d2db22 [Uwe L. Korn] ARROW-91: Basic Parquet read support d9940d8 [Wes McKinney] Public API draft
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.