ARROW-9014: [Packaging] Bump the minor part of the automatically generated version in crossbow #7327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit wheel-manylinux1-cp36m |
|
The produced wheel should have version number: |
|
Revision: 838509c Submitted crossbow builds: ursa-labs/crossbow @ actions-281
|
pitrou
reviewed
Jun 3, 2020
pitrou
reviewed
Jun 3, 2020
| major, minor, patch = map(int, match.groups()) | ||
|
|
||
| # the bumped version number after 0.17.x will be 0.18.0.dev300 | ||
| return "{}.{}.{}.dev{}".format(major, minor + 1, patch, version.distance) |
There was a problem hiding this comment.
Are you sure patch is 0 here? Otherwise you could get e.g. 0.18.1.dev300.
There was a problem hiding this comment.
Since the packaging builds are executed from the master branch we should have patch equal to zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crossbow uses setuptools_scm to generate a development version number using git describe command. This means that it finds the latest reachable tag from the current commit on master.
The minor releases are created from the master branch whereas the patch release tags point to commits on maintenance branches (like 0.17.x) which means that if we already have released a patch version, like 0.17.1 then crossbow generates a version number like 0.17.0.dev
{number-of-commits-from-0.17.0}
and bumps its patch tag, eventually creating binary packages with version 0.17.1.dev123.
The main problem with this is that the produced nightly python wheels are not picked up by pip, because on pypi we already have that patch release available and pip doesn't consider 0.17.1.dev123 newer than 0.17.1 (with --pre option passed).
So to force pip to install the newer nightly packages we need to bump the minor version instead.