ARROW-9088: [Rust] Make prettyprint optional #7400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not compile under the wasm target
houqp
approved these changes
Jun 13, 2020
|
It's odd that a pretty print library would be have target specific issues :P |
|
@houqp actually |
andygrove
approved these changes
Jun 16, 2020
jorgecarleitao
pushed a commit
that referenced
this pull request
Oct 8, 2020
… builds This PR makes `array_value_to_string` available to all arrow builds. Currently it is only available if the `feature = "prettyprint"` is enabled which is not the default. The full `print_batches` and `pretty_format_batches` (and the libraries they depend on) are still only available of the feature flag is set. The rationale for making this change is that I want to be able to use `array_value_to_string` to write tests (such as on #8346) but currently it is only available when `feature = "prettyprint"` is enabled. It appears that @nevi-me made prettyprint compilation optional so that arrow could be compiled for wasm in #7400. https://issues.apache.org/jira/browse/ARROW-9088 explains that this is due to some dependency of pretty-table; `array_value_to_string` has no needed dependencies. Note I tried to compile ARROW again using the `wasm32-unknown-unknown` target on master and it fails (perhaps due to a new dependency that was added?): <details> <summary>Click to expand!</summary> ``` alamb@ip-192-168-0-182 rust % git log | head -n 1 git log | head -n 1 commit d4cbc4b alamb@ip-192-168-0-182 rust % git status git status On branch master Your branch is up to date with 'upstream/master'. nothing to commit, working tree clean alamb@ip-192-168-0-182 rust % alamb@ip-192-168-0-182 rust % cargo build --target=wasm32-unknown-unknown cargo build --target=wasm32-unknown-unknown Compiling cfg-if v0.1.10 Compiling lazy_static v1.4.0 Compiling futures-core v0.3.5 Compiling slab v0.4.2 Compiling futures-sink v0.3.5 Compiling once_cell v1.4.0 Compiling pin-utils v0.1.0 Compiling futures-io v0.3.5 Compiling itoa v0.4.5 Compiling bytes v0.5.4 Compiling fnv v1.0.7 Compiling iovec v0.1.4 Compiling unicode-width v0.1.7 Compiling pin-project-lite v0.1.7 Compiling ppv-lite86 v0.2.8 Compiling atty v0.2.14 Compiling dirs v1.0.5 Compiling smallvec v1.4.0 Compiling regex-syntax v0.6.18 Compiling encode_unicode v0.3.6 Compiling hex v0.4.2 Compiling tower-service v0.3.0 error[E0433]: failed to resolve: could not find `unix` in `os` --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/dirs-1.0.5/src/lin.rs:41:18 | 41 | use std::os::unix::ffi::OsStringExt; | ^^^^ could not find `unix` in `os` error[E0432]: unresolved import `unix` --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/dirs-1.0.5/src/lin.rs:6:5 | 6 | use unix; | ^^^^ no `unix` in the root Compiling alloc-no-stdlib v2.0.1 Compiling adler32 v1.0.4 error[E0599]: no function or associated item named `from_vec` found for struct `std::ffi::OsString` in the current scope --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/dirs-1.0.5/src/lin.rs:48:34 | 48 | Some(PathBuf::from(OsString::from_vec(out))) | ^^^^^^^^ function or associated item not found in `std::ffi::OsString` | = help: items from traits can only be used if the trait is in scope = note: the following trait is implemented but not in scope; perhaps add a `use` for it: `use std::sys_common::os_str_bytes::OsStringExt;` error: aborting due to 3 previous errors Some errors have detailed explanations: E0432, E0433, E0599. For more information about an error, try `rustc --explain E0432`. error: could not compile `dirs`. To learn more, run the command again with --verbose. warning: build failed, waiting for other jobs to finish... error: build failed alamb@ip-192-168-0-182 rust % ``` </details> Closes #8397 from alamb/alamb/consolidate-array-value-to-string Lead-authored-by: alamb <andrew@nerdnetworks.org> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
alamb
added a commit
to apache/arrow-rs
that referenced
this pull request
Apr 20, 2021
… builds This PR makes `array_value_to_string` available to all arrow builds. Currently it is only available if the `feature = "prettyprint"` is enabled which is not the default. The full `print_batches` and `pretty_format_batches` (and the libraries they depend on) are still only available of the feature flag is set. The rationale for making this change is that I want to be able to use `array_value_to_string` to write tests (such as on apache/arrow#8346) but currently it is only available when `feature = "prettyprint"` is enabled. It appears that @nevi-me made prettyprint compilation optional so that arrow could be compiled for wasm in apache/arrow#7400. https://issues.apache.org/jira/browse/ARROW-9088 explains that this is due to some dependency of pretty-table; `array_value_to_string` has no needed dependencies. Note I tried to compile ARROW again using the `wasm32-unknown-unknown` target on master and it fails (perhaps due to a new dependency that was added?): <details> <summary>Click to expand!</summary> ``` alamb@ip-192-168-0-182 rust % git log | head -n 1 git log | head -n 1 commit d4cbc4b alamb@ip-192-168-0-182 rust % git status git status On branch master Your branch is up to date with 'upstream/master'. nothing to commit, working tree clean alamb@ip-192-168-0-182 rust % alamb@ip-192-168-0-182 rust % cargo build --target=wasm32-unknown-unknown cargo build --target=wasm32-unknown-unknown Compiling cfg-if v0.1.10 Compiling lazy_static v1.4.0 Compiling futures-core v0.3.5 Compiling slab v0.4.2 Compiling futures-sink v0.3.5 Compiling once_cell v1.4.0 Compiling pin-utils v0.1.0 Compiling futures-io v0.3.5 Compiling itoa v0.4.5 Compiling bytes v0.5.4 Compiling fnv v1.0.7 Compiling iovec v0.1.4 Compiling unicode-width v0.1.7 Compiling pin-project-lite v0.1.7 Compiling ppv-lite86 v0.2.8 Compiling atty v0.2.14 Compiling dirs v1.0.5 Compiling smallvec v1.4.0 Compiling regex-syntax v0.6.18 Compiling encode_unicode v0.3.6 Compiling hex v0.4.2 Compiling tower-service v0.3.0 error[E0433]: failed to resolve: could not find `unix` in `os` --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/dirs-1.0.5/src/lin.rs:41:18 | 41 | use std::os::unix::ffi::OsStringExt; | ^^^^ could not find `unix` in `os` error[E0432]: unresolved import `unix` --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/dirs-1.0.5/src/lin.rs:6:5 | 6 | use unix; | ^^^^ no `unix` in the root Compiling alloc-no-stdlib v2.0.1 Compiling adler32 v1.0.4 error[E0599]: no function or associated item named `from_vec` found for struct `std::ffi::OsString` in the current scope --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/dirs-1.0.5/src/lin.rs:48:34 | 48 | Some(PathBuf::from(OsString::from_vec(out))) | ^^^^^^^^ function or associated item not found in `std::ffi::OsString` | = help: items from traits can only be used if the trait is in scope = note: the following trait is implemented but not in scope; perhaps add a `use` for it: `use std::sys_common::os_str_bytes::OsStringExt;` error: aborting due to 3 previous errors Some errors have detailed explanations: E0432, E0433, E0599. For more information about an error, try `rustc --explain E0432`. error: could not compile `dirs`. To learn more, run the command again with --verbose. warning: build failed, waiting for other jobs to finish... error: build failed alamb@ip-192-168-0-182 rust % ``` </details> Closes #8397 from alamb/alamb/consolidate-array-value-to-string Lead-authored-by: alamb <andrew@nerdnetworks.org> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
… builds This PR makes `array_value_to_string` available to all arrow builds. Currently it is only available if the `feature = "prettyprint"` is enabled which is not the default. The full `print_batches` and `pretty_format_batches` (and the libraries they depend on) are still only available of the feature flag is set. The rationale for making this change is that I want to be able to use `array_value_to_string` to write tests (such as on apache#8346) but currently it is only available when `feature = "prettyprint"` is enabled. It appears that @nevi-me made prettyprint compilation optional so that arrow could be compiled for wasm in apache#7400. https://issues.apache.org/jira/browse/ARROW-9088 explains that this is due to some dependency of pretty-table; `array_value_to_string` has no needed dependencies. Note I tried to compile ARROW again using the `wasm32-unknown-unknown` target on master and it fails (perhaps due to a new dependency that was added?): <details> <summary>Click to expand!</summary> ``` alamb@ip-192-168-0-182 rust % git log | head -n 1 git log | head -n 1 commit d4cbc4b alamb@ip-192-168-0-182 rust % git status git status On branch master Your branch is up to date with 'upstream/master'. nothing to commit, working tree clean alamb@ip-192-168-0-182 rust % alamb@ip-192-168-0-182 rust % cargo build --target=wasm32-unknown-unknown cargo build --target=wasm32-unknown-unknown Compiling cfg-if v0.1.10 Compiling lazy_static v1.4.0 Compiling futures-core v0.3.5 Compiling slab v0.4.2 Compiling futures-sink v0.3.5 Compiling once_cell v1.4.0 Compiling pin-utils v0.1.0 Compiling futures-io v0.3.5 Compiling itoa v0.4.5 Compiling bytes v0.5.4 Compiling fnv v1.0.7 Compiling iovec v0.1.4 Compiling unicode-width v0.1.7 Compiling pin-project-lite v0.1.7 Compiling ppv-lite86 v0.2.8 Compiling atty v0.2.14 Compiling dirs v1.0.5 Compiling smallvec v1.4.0 Compiling regex-syntax v0.6.18 Compiling encode_unicode v0.3.6 Compiling hex v0.4.2 Compiling tower-service v0.3.0 error[E0433]: failed to resolve: could not find `unix` in `os` --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/dirs-1.0.5/src/lin.rs:41:18 | 41 | use std::os::unix::ffi::OsStringExt; | ^^^^ could not find `unix` in `os` error[E0432]: unresolved import `unix` --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/dirs-1.0.5/src/lin.rs:6:5 | 6 | use unix; | ^^^^ no `unix` in the root Compiling alloc-no-stdlib v2.0.1 Compiling adler32 v1.0.4 error[E0599]: no function or associated item named `from_vec` found for struct `std::ffi::OsString` in the current scope --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/dirs-1.0.5/src/lin.rs:48:34 | 48 | Some(PathBuf::from(OsString::from_vec(out))) | ^^^^^^^^ function or associated item not found in `std::ffi::OsString` | = help: items from traits can only be used if the trait is in scope = note: the following trait is implemented but not in scope; perhaps add a `use` for it: `use std::sys_common::os_str_bytes::OsStringExt;` error: aborting due to 3 previous errors Some errors have detailed explanations: E0432, E0433, E0599. For more information about an error, try `rustc --explain E0432`. error: could not compile `dirs`. To learn more, run the command again with --verbose. warning: build failed, waiting for other jobs to finish... error: build failed alamb@ip-192-168-0-182 rust % ``` </details> Closes apache#8397 from alamb/alamb/consolidate-array-value-to-string Lead-authored-by: alamb <andrew@nerdnetworks.org> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
This was referenced Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not compile under the wasm target