ARROW-9448: [Java] fix empty ArrowBuf getting a null log in debug mode #7742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @rymurr |
rymurr
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
Thanks for the fix @lidavidm I wouldn't have even considered order of statics and their side effects! (clearly)
I am going to take a deeper look at why we even expose a default config object. I don't think we use it anywhere and I don't like all the initialisation order dependent statics.
|
Thanks for the review. I'll merge this to fix the bug for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.