ARROW-9758 [Rust] [DataFusion] Rename PhysicalPlannerImpl to DefaultPhysicalPlanner #7980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/arrow-9758-rename
branch
from
b6099bf
to
155724e
Compare
andygrove
reviewed
Aug 17, 2020
| @@ -33,7 +33,8 @@ use arrow::{ | |||
| }; | |||
| use udf::ScalarFunction; | |||
|
|
|||
| /// Physical query planner | |||
| /// Physical query planner that converts a `LogicalPlan` to an | |||
| /// `ExecutionPlan` suitable for execution. | |||
There was a problem hiding this comment.
Note that in the rustdoc format we can actually link to other items. e.g. [ExecutionPlan](trait.ExecutionPlan.html)
jorisvandenbossche
changed the title
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Sep 8, 2020
…hysicalPlanner Proposed follow up to apache#7975 -- rename `PhysicalPlannerImpl` to `DefaultPhysicalPlanner` to better describe what it is and that the design allows for more than one. I considered a more specific name like `SingleNodeMultiThreadedPlanner` but I felt a lot of that was a function of the Physical nodes that got created rather than the planner itself. Closes apache#7980 from alamb/alamb/arrow-9758-rename Authored-by: alamb <andrew@nerdnetworks.org> Signed-off-by: Andy Grove <andygrove73@gmail.com>
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
…hysicalPlanner Proposed follow up to apache#7975 -- rename `PhysicalPlannerImpl` to `DefaultPhysicalPlanner` to better describe what it is and that the design allows for more than one. I considered a more specific name like `SingleNodeMultiThreadedPlanner` but I felt a lot of that was a function of the Physical nodes that got created rather than the planner itself. Closes apache#7980 from alamb/alamb/arrow-9758-rename Authored-by: alamb <andrew@nerdnetworks.org> Signed-off-by: Andy Grove <andygrove73@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…hysicalPlanner Proposed follow up to apache#7975 -- rename `PhysicalPlannerImpl` to `DefaultPhysicalPlanner` to better describe what it is and that the design allows for more than one. I considered a more specific name like `SingleNodeMultiThreadedPlanner` but I felt a lot of that was a function of the Physical nodes that got created rather than the planner itself. Closes apache#7980 from alamb/alamb/arrow-9758-rename Authored-by: alamb <andrew@nerdnetworks.org> Signed-off-by: Andy Grove <andygrove73@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed follow up to #7975 -- rename
PhysicalPlannerImpltoDefaultPhysicalPlannerto better describe what it is and that the design allows for more than one.I considered a more specific name like
SingleNodeMultiThreadedPlannerbut I felt a lot of that was a function of the Physical nodes that got created rather than the planner itself.