ARROW-10013: [FlightRPC][C++] fix setting generic client options #8196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MacOS test flakes due to the filesystem issue; there are new Flight test failures on Windows in Python. |
lidavidm
force-pushed
the
arrow-10013
branch
3 times, most recently
from
d68c341
to
690a76d
Compare
|
On Windows, gRPC is apparently corrupting ServerContext::peer(), causing a test failure... |
lidavidm
force-pushed
the
arrow-10013
branch
4 times, most recently
from
d4b3f8e
to
1bff809
Compare
|
I'm going to hold this until the AWS SDK issues are resolved. The patch here should fix the MacOS tests and works around the Windows issues. |
lidavidm
force-pushed
the
arrow-10013
branch
from
1bff809
to
384f9e5
Compare
lidavidm
force-pushed
the
arrow-10013
branch
from
384f9e5
to
aaadb40
Compare
|
CC @pitrou, this will finally let AppVeyor pass again :) |
|
Wow, did you report the |
Not yet - I need to reproduce it in a VM first (probably with just base gRPC instead of trying to set up Arrow). |
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
Some gRPC version upgrade meant that for settings that were present twice, the first value was taken instead of the last value. This changes how we set default options to avoid this issue. Closes apache#8196 from lidavidm/arrow-10013 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Some gRPC version upgrade meant that for settings that were present twice, the first value was taken instead of the last value. This changes how we set default options to avoid this issue. Closes apache#8196 from lidavidm/arrow-10013 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some gRPC version upgrade meant that for settings that were present twice, the first value was taken instead of the last value. This changes how we set default options to avoid this issue.