ARROW-10574: [Python][Parquet] Allow collections for 'in' / 'not in' filter (in addition to sets) #8672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyzhao
force-pushed
the
feature/partition_filter
branch
2 times, most recently
from
35cc90a
to
a7794d4
Compare
wyzhao
force-pushed
the
feature/partition_filter
branch
from
ad15ec2
to
cc5b97d
Compare
added 4 commits
December 5, 2020 16:53
wyzhao
force-pushed
the
feature/partition_filter
branch
from
cc5b97d
to
d66369e
Compare
|
Hi Joris, Thank you for reviewing my work. I saw that python 3.5 is not supported any more, so I changed back to use "Collection" as you suggested. I believe everything is taken care of. Please review. Weiyang |
jorisvandenbossche
changed the title
|
Thanks @wyzhao ! |
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…filter (in addition to sets) I would like to enhance partition filters in methods such as: pyarrow.parquet.ParquetDataset(path, filters) I am proposing the below enhancements: 1. for operator "in", "not in", the value should be any typing.Iteratable (also a container). But currently only set is supported while other iteratable, such as list, tuple cannot function correctly. I would like to change it to accept any iteratable. 2. Enhance the documents about the partition filters. I see there is a new version implemented with _ParquetDatasetV2 which passed my tests with an iterable for "in" and "not in". So the documentation update is fine for the new version as well. Closes apache#8672 from wyzhao/feature/partition_filter Lead-authored-by: Weiyang Zhao <weiyzha@blackrock.com> Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to enhance partition filters in methods such as:
pyarrow.parquet.ParquetDataset(path, filters)
I am proposing the below enhancements:
for operator "in", "not in", the value should be any typing.Iteratable (also a container). But currently only set is supported while other iteratable, such as list, tuple cannot function correctly. I would like to change it to accept any iteratable.
Enhance the documents about the partition filters.
I see there is a new version implemented with _ParquetDatasetV2 which passed my tests with an iterable for "in" and "not in". So the documentation update is fine for the new version as well.