ARROW-10685: [Rust] [DataFusion] Added support for Join on filter-pushdown optimizer. #8738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @andygrove and @alamb :) |
jorgecarleitao
commented
Nov 22, 2020
| left_cols, | ||
| right_cols, | ||
| )? | ||
| .join(&right.to_logical_plan(), join_type, left_cols, right_cols)? |
There was a problem hiding this comment.
this is unrelated: it is just a small simplification to the signature of LogicalPlanBuilder::join to not require the Arc.
andygrove
reviewed
Nov 22, 2020
andygrove
approved these changes
Nov 22, 2020
|
@jorgecarleitao could you try pushing an empty commit to trigger CI again? |
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…hdown optimizer. This PR extends the filter pushdown optimizer to support nodes of multiple children. In the context of the `join`, this allows to push filters down the joins. E.g. ``` "\ Filter: #a LtEq Int64(1)\ \n Join: a = a\ \n TableScan: test projection=None\ \n TableScan: test projection=None" ``` is optimized to ``` "\ Join: a = a\ \n Filter: #a LtEq Int64(1)\ \n TableScan: test projection=None\ \n Filter: #a LtEq Int64(1)\ \n TableScan: test projection=None" ``` This also reduces the complexity of the optimizer by making it perform a single pass on the plan. Naturally, this has a major implication in performance as the `join` is an expensive operation. Closes apache#8738 from jorgecarleitao/filter_push Authored-by: Jorge C. Leitao <jorgecarleitao@gmail.com> Signed-off-by: Andy Grove <andygrove73@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the filter pushdown optimizer to support nodes of multiple children. In the context of the
join, this allows to push filters down the joins. E.g.is optimized to
This also reduces the complexity of the optimizer by making it perform a single pass on the plan.
Naturally, this has a major implication in performance as the
joinis an expensive operation.