ARROW-10710: [Rust] Revert tokio upgrade, go back to 0.2 #8769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevi-me
changed the title
Dandandan
reviewed
Nov 25, 2020
Dandandan
reviewed
Nov 25, 2020
|
FYI @jorgecarleitao |
jorgecarleitao
approved these changes
Nov 25, 2020
I also found a regression related to this update in This reverts commit 4192891.
Dandandan
approved these changes
Nov 25, 2020
|
I am waiting for CI to finish running and then I will merge this in |
|
CI is green -- merging this in! |
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
## Changes This PR backs out the version upgrade to tokio done in apache#8697 and also partly by @andygrove in apache#8734 (see comment apache#8697 (comment) by @rdettai for more details). ## Rationale: It seems as if the new version of tokio (0.3) has some fairly substantial changes, and some of the higher level libraries built on top of tokio that are used in the flight implementation do not yet support version 0.3 of tokio. This results in parts of the code (flight server) using the older version of tokio and parts of the code (datafusion) using newer versions of tokio which causes ... issues. This issue can be seen in the flight example linked in https://issues.apache.org/jira/browse/ARROW-10710 and I saw it when I tried to upgrade to latest arrow in https://github.com/influxdata/influxdb_iox For example, https://crates.io/crates/tonic appears to require tokio < 0.3 <img width="350" alt="Screen Shot 2020-11-25 at 7 10 21 AM" src="https://user-images.githubusercontent.com/490673/100227458-2eabbb00-2eef-11eb-82a8-eb11dad03bc2.png"> cc @Dandandan and @nevi-me Closes apache#8769 from alamb/alamb/ARROW-10710-fix-fligh Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR backs out the version upgrade to tokio done in #8697 and also partly by @andygrove in #8734 (see comment #8697 (comment) by @rdettai for more details).
Rationale:
It seems as if the new version of tokio (0.3) has some fairly substantial changes, and some of the higher level libraries built on top of tokio that are used in the flight implementation do not yet support version 0.3 of tokio. This results in parts of the code (flight server) using the older version of tokio and parts of the code (datafusion) using newer versions of tokio which causes ... issues.
This issue can be seen in the flight example linked in https://issues.apache.org/jira/browse/ARROW-10710 and I saw it when I tried to upgrade to latest arrow in https://github.com/influxdata/influxdb_iox
For example, https://crates.io/crates/tonic appears to require tokio < 0.3
cc @Dandandan and @nevi-me