New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-10627: [Rust] Loosen cfg restrictions for wasm32 #8798
Conversation
One of our recent changes made compiling under non-x86/amd64 platforms to return errors. This removes those restrictions as a quick fix. I'm a bit wary of introducing `wasm32` targets into CI for now, as the tests don't yet work. There is also a separate JIRA for this work, so I'm not including it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We could place it as a cron job. The issue is that those do not report anywhere AFAIK :(
I thought of that, but the lack of reporting other than an ignoreable e-mail is a deterrent. |
IMO we should refactor the CI: each compilation should be a different job with a diffetent cache so that everything can be done in parallel. |
Different job per crate, or per target? ( |
(this is not for now and not blocking this PR, it is just a thought) Not necessarily per target or crate: As I see it, we have builds that we do sequentially on the More generally, our builds are basically a DAG where each node is an execution that benefits from having artifacts available:
A feature flag is a new build of the lib+bin, but typically shares the same external dependencies and thus would be something like
Each tuple Currently we run our DAG in sequence. However, there are many nodes on this DAG that do not depend on each other and can run in parallel (different jobs in github flow). IMO if we split our build in different jobs that outputs an artifact and create a DAG of these jobs, we are able to run our pipeline faster by leveraging parallelism of the build. This is something that I fielded on the mailing list in the context of the integration tests, but that it is also applicable to our own builds. |
I don't have much experience with Github Actions, but I know that Gitlab CI allows one to express that DAG structure very well; so I understand what you mean. |
One of our recent changes made compiling under non-x86/amd64 platforms to return errors. This removes those restrictions as a quick fix. I'm a bit wary of introducing `wasm32` targets into CI for now, as the tests don't yet work, and we would just increase CI time for everyone. There is also a separate JIRA for this work, so I'm not including it here. Closes apache#8798 from nevi-me/ARROW-10627 Authored-by: Neville Dipale <nevilledips@gmail.com> Signed-off-by: Andy Grove <andygrove73@gmail.com>
One of our recent changes made compiling under non-x86/amd64 platforms to return errors.
This removes those restrictions as a quick fix.
I'm a bit wary of introducing
wasm32
targets into CI for now, as the tests don't yet work, and we would just increase CI time for everyone.There is also a separate JIRA for this work, so I'm not including it here.