Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-10825: [Rust] Added support for NullArray to MutableArrayData #8851

Closed
wants to merge 1 commit into from
Closed

ARROW-10825: [Rust] Added support for NullArray to MutableArrayData #8851

wants to merge 1 commit into from

Conversation

jorgecarleitao
Copy link
Member

No description provided.

@jorgecarleitao jorgecarleitao marked this pull request as draft December 6, 2020 09:02
@jorgecarleitao
Copy link
Member Author

This is awaiting #8849 to build

@github-actions
Copy link

github-actions bot commented Dec 6, 2020

https://issues.apache.org/jira/browse/ARROW-10825

@jorgecarleitao jorgecarleitao mentioned this pull request Dec 6, 2020
Closed
@jorgecarleitao jorgecarleitao marked this pull request as ready for review December 6, 2020 19:15
@github-actions github-actions bot added needs-rebase A PR that needs to be rebased by the author and removed needs-rebase A PR that needs to be rebased by the author labels Dec 7, 2020
@codecov-io
Copy link

codecov-io commented Dec 9, 2020 •
edited
Loading

Codecov Report

Merging #8851 (e19e891) into master (51672b2) will increase coverage by 0.00%.
The diff coverage is 94.44%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8851   +/-   ##
=======================================
  Coverage   82.61%   82.62%           
=======================================
  Files         202      203    +1     
  Lines       50048    50065   +17     
=======================================
+ Hits        41347    41364   +17     
  Misses       8701     8701
Impacted Files Coverage Δ
rust/arrow/src/array/transform/null.rs 66.66% <66.66%> (ø)
rust/arrow/src/array/transform/mod.rs 88.29% <100.00%> (+0.09%) ⬆️
rust/arrow/src/array/equal/mod.rs 92.32% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51672b2...e19e891. Read the comment docs.

@jorgecarleitao jorgecarleitao deleted the mutable_null branch December 13, 2020 09:15
@jorgecarleitao jorgecarleitao restored the mutable_null branch December 23, 2020 15:26
@github-actions github-actions bot added needs-rebase A PR that needs to be rebased by the author and removed needs-rebase A PR that needs to be rebased by the author labels Dec 23, 2020
@alamb
Copy link
Contributor

alamb commented Dec 31, 2020

The full set of Rust CI tests did not run on this PR :(

Can you please rebase this PR against apache/master to pick up the changes in #9056 so that they do?

I apologize for the inconvenience.

@jorgecarleitao jorgecarleitao removed the needs-rebase A PR that needs to be rebased by the author label Jan 1, 2021
alamb
alamb approved these changes Jan 1, 2021
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a read, and ran the tests locally. Looks good to me.

@alamb alamb closed this in cc0ee5e Jan 1, 2021
@jorgecarleitao jorgecarleitao deleted the mutable_null branch January 1, 2021 11:15
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
@jorgecarleitao @GeorgeAp
ARROW-10825: [Rust] Added support for NullArray to MutableArrayData
b3dbcb2 
Closes apache#8851 from jorgecarleitao/mutable_null

Authored-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
@asfimport asfimport mentioned this pull request Jan 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
Component: Rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jorgecarleitao @codecov-io @alamb