Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-11085: [Rust] Migrated from action-rs to shell in github actions. #9056

Closed
wants to merge 1 commit into from
Closed

ARROW-11085: [Rust] Migrated from action-rs to shell in github actions. #9056

wants to merge 1 commit into from

Conversation

jorgecarleitao
Copy link
Member

@jorgecarleitao jorgecarleitao commented Dec 31, 2020

This addresses a blocker in our pipeline causing all CIs to not run due to a policy change by the INFRA team.

See https://issues.apache.org/jira/browse/INFRA-21234 and https://issues.apache.org/jira/browse/INFRA-21239 for more details.

@github-actions
Copy link

This addresses a blocker in our pipeline
@jorgecarleitao
Copy link
Member Author

@codecov-io
Copy link

Codecov Report

Merging #9056 (23c6003) into master (2f68741) will decrease coverage by 0.23%.
The diff coverage is 68.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9056      +/-   ##
==========================================
- Coverage   82.87%   82.64%   -0.24%     
==========================================
  Files         201      202       +1     
  Lines       49737    50044     +307     
==========================================
+ Hits        41219    41357     +138     
- Misses       8518     8687     +169     
Impacted Files Coverage Δ
rust/arrow/src/array/equal/mod.rs 91.94% <ø> (ø)
rust/arrow/src/compute/kernels/take.rs 95.21% <ø> (-0.04%) ⬇️
rust/arrow/src/compute/util.rs 98.93% <ø> (ø)
rust/arrow/src/json/reader.rs 81.49% <ø> (ø)
rust/arrow/src/util/test_util.rs 90.90% <ø> (ø)
rust/datafusion/examples/flight_server.rs 0.00% <0.00%> (ø)
rust/datafusion/src/datasource/csv.rs 81.25% <ø> (ø)
rust/datafusion/src/datasource/datasource.rs 100.00% <ø> (ø)
rust/datafusion/src/datasource/empty.rs 70.58% <ø> (ø)
rust/datafusion/src/logical_plan/builder.rs 88.26% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2440c9e...23c6003. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the changes to the workflows files and I understand them all.

I also reviewed the actual test runs on this PR (https://github.com/apache/arrow/actions/runs/454322405) and the tests all look good to me

Thank you so much for figuring this out @jorgecarleitao -- I'll merge this PR in and then ping all outstanding Rust PRs asking them to rebase so the CI runs.

👍 👍 ❤️ 👍 👍

default: true
components: rustfmt
- name: Setup Rust toolchain
run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb closed this in cf0ef79 Dec 31, 2020
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
This addresses a blocker in our pipeline causing all CIs to not run due to a policy change by the INFRA team.

See https://issues.apache.org/jira/browse/INFRA-21234 and https://issues.apache.org/jira/browse/INFRA-21239 for more details.

Closes apache#9056 from jorgecarleitao/rust_actions

Authored-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants