ARROW-10656: [Rust] Allow schema validation to ignore field names and only check data types on new batch #8988
Conversation
nevi-me
changed the title
|
Hi @ch-sc , please have a look at the approach that I've taken, and let me know if it meets your use-case. If you're happy with the PR, I can then document the new functions, and add unit tests, then get it reviewed. Thanks |
nevi-me
changed the title
Codecov Report
@@ Coverage Diff @@
## master #8988 +/- ##
==========================================
- Coverage 82.61% 82.56% -0.06%
==========================================
Files 202 202
Lines 50048 50087 +39
==========================================
+ Hits 41347 41353 +6
- Misses 8701 8734 +33
Continue to review full report at Codecov.
|
|
Looks good to me @nevi-me. Thank you! |
|
The full set of Rust CI tests did not run on this PR :( Can you please rebase this PR against apache/master to pick up the changes in #9056 so that they do? I apologize for the inconvenience. |
|
Done rebasing @alamb |
alamb
changed the title
| Ok(RecordBatch { schema, columns }) | ||
| } | ||
|
|
||
| pub fn try_new_with_options( |
There was a problem hiding this comment.
@alamb @jorgecarleitao I must have done something wrong on the rebase, I had added doc comments for this function, and added tests :(
… only check data types on new batch This adds the option to create a new record batch with less strict validation for list field names. The default behaviour is preserved. Closes apache#8988 from nevi-me/ARROW-10656 Authored-by: Neville Dipale <nevilledips@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
This adds the option to create a new record batch with less strict validation for list field names.
The default behaviour is preserved.