ARROW-11082: [Rust] C data interface to largeUTF8 #9054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The full set of Rust CI tests did not run on this PR :( Can you please rebase this PR against apache/master to pick up the changes in #9056 so that they do? I apologize for the inconvenience. |
nevi-me
approved these changes
Jan 1, 2021
rust/arrow/src/ffi.rs
Outdated
| @@ -624,10 +650,10 @@ mod tests { | |||
| } | |||
| // case with nulls is tested in the docs, through the example on this module. | |||
|
|
|||
| #[test] | |||
| fn test_string() -> Result<()> { | |||
| fn test_genetic_string<Offset: StringOffsetSizeTrait>() -> Result<()> { | |||
There was a problem hiding this comment.
Suggested change
| fn test_genetic_string<Offset: StringOffsetSizeTrait>() -> Result<()> { | |
| fn test_generic_string<Offset: StringOffsetSizeTrait>() -> Result<()> { |
| } | ||
|
|
||
| #[test] | ||
| fn test_bool() -> Result<()> { |
Codecov Report
@@ Coverage Diff @@
## master #9054 +/- ##
==========================================
+ Coverage 82.61% 82.62% +0.01%
==========================================
Files 202 202
Lines 50048 50068 +20
==========================================
+ Hits 41347 41370 +23
+ Misses 8701 8698 -3
Continue to review full report at Codecov.
|
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
This also simplifies some code and adds a test for the boolean case, which is special due to bit-packing. Closes apache#9054 from jorgecarleitao/ffi_large_string Authored-by: Jorge C. Leitao <jorgecarleitao@gmail.com> Signed-off-by: Neville Dipale <nevilledips@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also simplifies some code and adds a test for the boolean case, which is special due to bit-packing.