ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect #9127
Conversation
|
I agree. Another advantage is that it focus development towards implementing that dialect. :) |
|
Makes sense to me, seems a strategy more are following lately? I would suggest to strive for compatibility with the PostgreSQL dialect, but also allow for some extensions such as functions that are not in PostgreSQL but still a valuable addition to DataFusion. |
|
@alamb thanks for organising this!
Yes, I was hoping once we reach a decision we can do a comparison between what we have and what Postgres has then just work through the list. |
Sounds like a good plan @seddonm1 -- given that postgres has more than 20 years of official releases I suspect the list will be long and distinguished :) |
|
I plan to merge this on Monday Jan 11 2021 unless I hear any objections |
|
|
||
| DataFusion implements a subset of the [PostgreSQL SQL dialect](https://www.postgresql.org/docs/current/functions.html) where possible. We explicitly choose a single dialect to maximize interoperability with other tools and allow reuse of the PostgreSQL documents and tutorials as much as possible. | ||
|
|
||
| Currently, only a subset of the PosgreSQL dialect is implemented, and we will document any deviations. |
There was a problem hiding this comment.
Do we have a list or table somewhere that shows what we currently support?
|
I was planning to put one together in the next few days
…On Sun, 10 Jan 2021, 10:00 pm Paddy Horan, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In rust/datafusion/README.md
<#9127 (comment)>:
> @@ -91,6 +91,13 @@ This library currently supports the following SQL constructs:
* `GROUP BY` together with one of the following aggregations: `MIN`, `MAX`, `COUNT`, `SUM`, `AVG`
* `ORDER BY` together with an expression and optional `ASC` or `DESC` and also optional `NULLS FIRST` or `NULLS LAST`
+## Supported Functions
+
+DataFusion implements a subset of the [PostgreSQL SQL dialect](https://www.postgresql.org/docs/current/functions.html) where possible. We explicitly choose a single dialect to maximize interoperability with other tools and allow reuse of the PostgreSQL documents and tutorials as much as possible.
+
+Currently, only a subset of the PosgreSQL dialect is implemented, and we will document any deviations.
Do we have a list or table somewhere that show what we currently support?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9127 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2O2UGHFZBNA72B6OJIAZLSZGCEHANCNFSM4VZFOD2A>
.
|
Codecov Report
@@ Coverage Diff @@
## master #9127 +/- ##
==========================================
- Coverage 82.59% 81.80% -0.80%
==========================================
Files 204 214 +10
Lines 50526 51383 +857
==========================================
+ Hits 41732 42033 +301
- Misses 8794 9350 +556
Continue to review full report at Codecov.
|
|
Given no other comments or opinions to the contrary I am merging this in |
…lect PROPOSAL Document postgres as the target SQL / function dialect and rationale for this choice. I will also send an email to the dev mailing list soliciting feedback There are several comments and more discussion on apache#9108 Closes apache#9127 from alamb/alamb/ARROW-11165-dialect Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
PROPOSAL Document postgres as the target SQL / function dialect and rationale for this choice. I will also send an email to the dev mailing list soliciting feedback
There are several comments and more discussion on #9108