ARROW-10834: [R] Fix print method for SubTreeFileSystem #9168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcook
commented
Jan 11, 2021
Comment on lines
-421
to
+426
| if (name %in% ls(x)) { | ||
| if (name %in% ls(envir = x)) { | ||
| get(name, x) | ||
| } else { | ||
| } else if (name %in% ls(envir = x$base_fs)) { | ||
| get(name, x$base_fs) | ||
| } else { | ||
| NULL |
There was a problem hiding this comment.
Using envir in these ls() calls stops this cryptic warning from being issued when the external pointer breaks:
In addition: Warning message:
In ls(x$base_fs) : ‘x$base_fs’ converted to character string
That warning comes from a part of the code in ls() that doesn't run if you pass the object as envir.
nealrichardson
approved these changes
Jan 12, 2021
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
This PR modifies ``` `$.SubTreeFileSystem` ``` to return `NULL` if the named object is not found in the object. This allows the `print()` method of `ArrowObject` to print `SubTreeFileSystem` objects without error. Closes apache#9168 from ianmcook/ARROW-10834 Authored-by: Ian Cook <ianmcook@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
`$.SubTreeFileSystem`to returnNULLif the named object is not found in the object. This allows theprint()method ofArrowObjectto printSubTreeFileSystemobjects without error.