ARROW-11222: [Rust] Catch up with flatbuffers 0.8.1 which had some UB problems fixed #9176
Conversation
|
The crate |
|
I suggest we hold off merging this PR until the Arrow 3.0 release is completed (happening in the next day or two) to minimize the chance we break something right before the release |
@alamb thanks for the review! Since there is no direct evidence that this PR can fix something in arrow, it's OK to me to hold off merging this PR. BTW, I've exploring the cause of CC @jorgecarleitao I'm glad if you can take time for this possible problem at this weekend, as you said :) |
nevi-me
changed the title
|
I apologize for the delay in merging Rust PRs -- the 3.0 release is being finalized now and are planning to minimize entropy by postponing merging changes not critical for the release until the process was complete. I hope the process is complete in the next few days. There is more discussion in the mailing list |
@alamb I understand the common releasing process that freezes pushing/merging unless for those fully tested or fatal bug fix, this is really important. You are welcome, no need to apologize at all 👍 |
|
I merged this branch (locally) to master and re-ran the tests to verify things still work. Everything still looks good, so merging it in. |
… problems fixed The major change of [flatbuffers 0.8.1](https://docs.rs/flatbuffers/0.8.1/flatbuffers/index.html) since 0.8.0 is google/flatbuffers#6393, which fixed some possible memory alignment issues. In this PR, the ipc/gen/*.rs files are generated by `regen.sh` as before, without any manual change. Closes #9176 from mqy/flatbuffers-0.8.1 Authored-by: mqy <meng.qingyou@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
… problems fixed The major change of [flatbuffers 0.8.1](https://docs.rs/flatbuffers/0.8.1/flatbuffers/index.html) since 0.8.0 is google/flatbuffers#6393, which fixed some possible memory alignment issues. In this PR, the ipc/gen/*.rs files are generated by `regen.sh` as before, without any manual change. Closes apache#9176 from mqy/flatbuffers-0.8.1 Authored-by: mqy <meng.qingyou@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
… problems fixed The major change of [flatbuffers 0.8.1](https://docs.rs/flatbuffers/0.8.1/flatbuffers/index.html) since 0.8.0 is google/flatbuffers#6393, which fixed some possible memory alignment issues. In this PR, the ipc/gen/*.rs files are generated by `regen.sh` as before, without any manual change. Closes apache#9176 from mqy/flatbuffers-0.8.1 Authored-by: mqy <meng.qingyou@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
The major change of flatbuffers 0.8.1 since 0.8.0 is google/flatbuffers#6393, which fixed some possible memory alignment issues.
In this PR, the ipc/gen/*.rs files are generated by
regen.shas before, without any manual change.