ARROW-11277: [C++] Workaround macOS 10.11: don't default construct consts #9267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Jan 19, 2021
| @@ -681,7 +681,7 @@ Result<Expression> FoldConstants(Expression expr) { | |||
| if (std::all_of(call->arguments.begin(), call->arguments.end(), | |||
| [](const Expression& argument) { return argument.literal(); })) { | |||
| // all arguments are literal; we can evaluate this subexpression *now* | |||
| static const Datum ignored_input; | |||
| static const Datum ignored_input = Datum{}; | |||
There was a problem hiding this comment.
Perhaps we can give Datum a default constructor?
There was a problem hiding this comment.
Datum has one already; resolution of that constructor is just failing here
pitrou
approved these changes
Jan 19, 2021
|
Thanks I'm going to test this patch on top of rc2. Btw the MacOS 10.11 target be be EOL for us in april/may (but I imagine RHEL users will have the same issues....) |
|
Thanks confirmed this works. With this patch I can build rc2 on macos 10.11 |
kszucs
pushed a commit
that referenced
this pull request
Jan 25, 2021
…nsts ```c++ /tmp/apache-arrow-20210116-6233-1jyrhk8/apache-arrow-3.0.0/cpp/src/arrow/dataset/expression.cc /tmp/apache-arrow-20210116-6233-1jyrhk8/apache-arrow-3.0.0/cpp/src/arrow/dataset/expression.cc:684:30: error: default initialization of an object of const type 'const arrow::Datum' without a user-provided default constructor static const Datum ignored_input; ``` Datum defines a default constructor but it doesn't seem to be found for const/constexpr decls Closes #9267 from bkietz/11277-Fix-compilation-error-in- Authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…nsts
```c++
/tmp/apache-arrow-20210116-6233-1jyrhk8/apache-arrow-3.0.0/cpp/src/arrow/dataset/expression.cc
/tmp/apache-arrow-20210116-6233-1jyrhk8/apache-arrow-3.0.0/cpp/src/arrow/dataset/expression.cc:684:30:
error: default initialization of an object of const type 'const arrow::Datum' without a user-provided default constructor
static const Datum ignored_input;
```
Datum defines a default constructor but it doesn't seem to be found for const/constexpr decls
Closes apache#9267 from bkietz/11277-Fix-compilation-error-in-
Authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
…nsts
```c++
/tmp/apache-arrow-20210116-6233-1jyrhk8/apache-arrow-3.0.0/cpp/src/arrow/dataset/expression.cc
/tmp/apache-arrow-20210116-6233-1jyrhk8/apache-arrow-3.0.0/cpp/src/arrow/dataset/expression.cc:684:30:
error: default initialization of an object of const type 'const arrow::Datum' without a user-provided default constructor
static const Datum ignored_input;
```
Datum defines a default constructor but it doesn't seem to be found for const/constexpr decls
Closes apache#9267 from bkietz/11277-Fix-compilation-error-in-
Authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datum defines a default constructor but it doesn't seem to be found for const/constexpr decls