Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache-arrow 3.0.0 #61

Merged
merged 2 commits into from
Jan 26, 2021
Merged

apache-arrow 3.0.0 #61

merged 2 commits into from
Jan 26, 2021

Conversation

nealrichardson
Copy link
Contributor

@jeroen
Copy link
Contributor

jeroen commented Jan 16, 2021

High-sierra looks OK but the build on el-capitain (osx 10.11) failed with:

/tmp/apache-arrow-20210116-6233-1jyrhk8/apache-arrow-3.0.0/cpp/src/arrow/dataset/expression.cc
/tmp/apache-arrow-20210116-6233-1jyrhk8/apache-arrow-3.0.0/cpp/src/arrow/dataset/expression.cc:684:30: error: default initialization of an object of const type 'const arrow::Datum' without a user-provided default constructor
          static const Datum ignored_input;
                             ^
                                          {}

and

In file included from /tmp/apache-arrow-20210116-6233-1jyrhk8/apache-arrow-3.0.0/cpp/src/arrow/io/caching.cc:26:
/tmp/apache-arrow-20210116-6233-1jyrhk8/apache-arrow-3.0.0/cpp/src/arrow/util/future.h:102:3: error: default initialization of an object of const type 'const struct ContinueFuture' without a user-provided default constructor
} Continue;
  ^
          {}
1 error generated.

So if we want to keep supporting R 3.6 we need to find a workaround for that.

@nealrichardson
Copy link
Contributor Author

nealrichardson commented Jan 16, 2021

Ok, we can work out a patch for that.
https://issues.apache.org/jira/browse/ARROW-11277

@jeroen
Copy link
Contributor

jeroen commented Jan 19, 2021

@bkietz do you have any suggestion how I can work around this?

@bkietz
Copy link

bkietz commented Jan 19, 2021

@jeroen apache/arrow#9267

@jeroen
Copy link
Contributor

jeroen commented Jan 19, 2021

Thanks let me test that

@jeroen
Copy link
Contributor

jeroen commented Jan 19, 2021

Seems to work, awesome.

@nealrichardson nealrichardson marked this pull request as ready for review January 26, 2021 02:41
@jeroen jeroen merged commit f5e1a49 into autobrew:master Jan 26, 2021
@nealrichardson nealrichardson deleted the patch-5 branch January 26, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants