ARROW-11462: [Developer] Remove needless quote from the default DOCKER_VOLUME_PREFIX #9391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use "", it means two characters string ('"' and '"') on
Linux (not on macOS. "" is an empty string on macOS). It's not an
empty string. We can use an empty string without quote on Linux.
|
Hmm, I see. Thanks for the fix! |
pitrou
approved these changes
Feb 2, 2021
nevi-me
pushed a commit
to nevi-me/arrow
that referenced
this pull request
Feb 13, 2021
…R_VOLUME_PREFIX
If we use "", it means two characters string ('"' and '"') on
Linux (not on macOS. "" is an empty string on macOS). It's not an
empty string. We can use an empty string without quote on Linux.
Closes apache#9391 from kou/developer-default-docker-volume-prefix
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…R_VOLUME_PREFIX
If we use "", it means two characters string ('"' and '"') on
Linux (not on macOS. "" is an empty string on macOS). It's not an
empty string. We can use an empty string without quote on Linux.
Closes apache#9391 from kou/developer-default-docker-volume-prefix
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
…R_VOLUME_PREFIX
If we use "", it means two characters string ('"' and '"') on
Linux (not on macOS. "" is an empty string on macOS). It's not an
empty string. We can use an empty string without quote on Linux.
Closes apache#9391 from kou/developer-default-docker-volume-prefix
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use "", it means two characters string ('"' and '"') on
Linux (not on macOS. "" is an empty string on macOS). It's not an
empty string. We can use an empty string without quote on Linux.