ARROW-11489: [Rust][DataFusion] Make DataFrame be Send + Sync #9406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
|
I did this in my personal fork and was planning to raise it with Andy. Glad this will be done 👍 |
alamb
force-pushed
the
alamb/dataframe_send_sync
branch
from
c1b63cb
to
e25edb1
Compare
alamb
changed the title
|
fyi @jorgecarleitao / @andygrove / @Dandandan |
jorgecarleitao
approved these changes
Feb 4, 2021
nevi-me
pushed a commit
to nevi-me/arrow
that referenced
this pull request
Feb 13, 2021
Inspired by a question on the mailing list [link]( https://lists.apache.org/thread.html/r8f81fae08346817fa283804037ed79a4309bb54aa8ed77c354d7baf0%40%3Cuser.arrow.apache.org%3E) Things need to be `Send` + `Sync` in order to be sent between threads (or async tasks). Thus we should make `DataFrame` require `Send` + `Sync` as well so as to be usable in async applications. Closes apache#9406 from alamb/alamb/dataframe_send_sync Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
maxburke
pushed a commit
to urbanlogiq/arrow
that referenced
this pull request
Mar 11, 2021
Inspired by a question on the mailing list [link]( https://lists.apache.org/thread.html/r8f81fae08346817fa283804037ed79a4309bb54aa8ed77c354d7baf0%40%3Cuser.arrow.apache.org%3E) Things need to be `Send` + `Sync` in order to be sent between threads (or async tasks). Thus we should make `DataFrame` require `Send` + `Sync` as well so as to be usable in async applications. Closes apache#9406 from alamb/alamb/dataframe_send_sync Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Inspired by a question on the mailing list [link]( https://lists.apache.org/thread.html/r8f81fae08346817fa283804037ed79a4309bb54aa8ed77c354d7baf0%40%3Cuser.arrow.apache.org%3E) Things need to be `Send` + `Sync` in order to be sent between threads (or async tasks). Thus we should make `DataFrame` require `Send` + `Sync` as well so as to be usable in async applications. Closes apache#9406 from alamb/alamb/dataframe_send_sync Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
Inspired by a question on the mailing list [link]( https://lists.apache.org/thread.html/r8f81fae08346817fa283804037ed79a4309bb54aa8ed77c354d7baf0%40%3Cuser.arrow.apache.org%3E) Things need to be `Send` + `Sync` in order to be sent between threads (or async tasks). Thus we should make `DataFrame` require `Send` + `Sync` as well so as to be usable in async applications. Closes apache#9406 from alamb/alamb/dataframe_send_sync Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by a question on the mailing list link
Things need to be
Send+Syncin order to be sent between threads (or async tasks). Thus we should makeDataFramerequireSend+Syncas well so as to be usable in async applications.