ARROW-11574: [Rust][DataFusion] Upgrade sqlparser to support parsing all TPC-H queries #9456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Feb 9, 2021
| @@ -386,7 +386,7 @@ fn create_logical_plan(ctx: &mut ExecutionContext, query: usize) -> Result<Logic | |||
| // where | |||
| // l_shipdate >= date '1994-01-01' | |||
| // and l_shipdate < date '1994-01-01' + interval '1' year | |||
| // and l_discount between 0.06 - 0.01 and 0.06 + 0.01 | |||
| // and l_discount between .06 - 0.01 and .06 + 0.01 | |||
There was a problem hiding this comment.
I don't think it really matters, but my reading of the TPCH spec (validation query) has 0.06 rather than .06.
http://tpc.org/tpc_documents_current_versions/pdf/tpc-h_v2.18.0.pdf
There was a problem hiding this comment.
Hm weird. I generated the queries some time ago in here: https://github.com/ballista-compute/sqlparser-rs/tree/main/tests/queries/tpch . maybe the code to generate the queries has been changed slightly
There was a problem hiding this comment.
Just ran https://github.com/databricks/tpch-dbgen again, it still generates the values as .06
There was a problem hiding this comment.
I think at the time I went through and copied them from the TPC-H document directly to ensure they were 100% aligned.
| @@ -2052,7 +2057,8 @@ mod tests { | |||
| fn select_simple_aggregate_with_groupby_non_column_expression_nested_and_not_resolvable( | |||
| ) { | |||
| // The query should fail, because age + 9 is not in the group by. | |||
| let sql = "SELECT ((age + 1) / 2) * (age + 9), MIN(first_name) FROM person GROUP BY age + 1"; | |||
| let sql = | |||
There was a problem hiding this comment.
this looks like a whitespace only change
|
I think this one is ready . FYI @andygrove |
|
Looks like there was a conflict with #9399, sorry @Dandandan |
Dandandan
force-pushed
the
sqlparser_upgrade
branch
from
db15617
to
e270a32
Compare
|
Thanks, fixed @alamb |
nevi-me
pushed a commit
to nevi-me/arrow
that referenced
this pull request
Feb 13, 2021
…all TPC-H queries This PR completes parsing support for the TPC-H queries. TPC-H 6 had a small change before compared to the original (`0.06` instead of `.06`) and the syntax for query 22 `substring(c_phone from 1 for 2)` is now supported. Closes apache#9456 from Dandandan/sqlparser_upgrade Authored-by: Heres, Daniel <danielheres@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
sgnkc
pushed a commit
to sgnkc/arrow
that referenced
this pull request
Feb 17, 2021
…all TPC-H queries This PR completes parsing support for the TPC-H queries. TPC-H 6 had a small change before compared to the original (`0.06` instead of `.06`) and the syntax for query 22 `substring(c_phone from 1 for 2)` is now supported. Closes apache#9456 from Dandandan/sqlparser_upgrade Authored-by: Heres, Daniel <danielheres@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…all TPC-H queries This PR completes parsing support for the TPC-H queries. TPC-H 6 had a small change before compared to the original (`0.06` instead of `.06`) and the syntax for query 22 `substring(c_phone from 1 for 2)` is now supported. Closes apache#9456 from Dandandan/sqlparser_upgrade Authored-by: Heres, Daniel <danielheres@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
…all TPC-H queries This PR completes parsing support for the TPC-H queries. TPC-H 6 had a small change before compared to the original (`0.06` instead of `.06`) and the syntax for query 22 `substring(c_phone from 1 for 2)` is now supported. Closes apache#9456 from Dandandan/sqlparser_upgrade Authored-by: Heres, Daniel <danielheres@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes parsing support for the TPC-H queries.
TPC-H 6 had a small change before compared to the original (
0.06instead of.06) and the syntax for query 22substring(c_phone from 1 for 2)is now supported.