ARROW-11607: [C++][Parquet] Update values_capacity_ when resetting. #9498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why values_capacity_ is different kept separately from the buffer, but there is check which does not reserve capacity again values_capacity_ is already the needed size. When ReleaseValues is called, we allocate a brand new empty buffer. I'm not really sure why this hasn't caused users more issues (maybe increasingly large row groups or some other phenonemon). This bug also highlight that our C++ tests have very limited coverage on batched reads. To fix this I added an batch read for every round trip test to confirm it yields the same values.
emkornfield
commented
Feb 15, 2021
| ASSERT_EQ(table->num_rows(), kValueSize + 1); | ||
| std::shared_ptr<Table> result; | ||
|
|
||
| ArrowReaderProperties read_options(/*use_threads=*/true); |
There was a problem hiding this comment.
sorry I left in some junk here, I'll clean itup tomorrow.
pitrou
approved these changes
Feb 16, 2021
| @@ -2475,6 +2520,27 @@ TEST(TestArrowReadWrite, TableWithChunkedColumns) { | |||
| } | |||
| } | |||
|
|
|||
| TEST(TestArrowReadWrite, ManySmallLists) { | |||
| // ARROW-11607: The actual scenaio this forces is no data reads for | |||
emkornfield
commented
Feb 16, 2021
|
@pitrou the python failures look like something CI infrastructure related or am I just not seeing the exception? |
|
I've restarted the CI failures, I suppose it's just a CI glitch. |
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
I'm not sure why values_capacity_ is different kept separately from the buffer, but there is check which does not reserve capacity again values_capacity_ is already the needed size. When ReleaseValues is called, we allocate a brand new empty buffer. I'm not really sure why this hasn't caused users more issues (maybe increasingly large row groups or some other phenonemon). This bug also highlight that our C++ tests have very limited coverage on batched reads. To fix this I added an batch read for every round trip test to confirm it yields the same values. Closes apache#9498 from emkornfield/ARROW-11607 Lead-authored-by: Micah Kornfield <emkornfield@gmail.com> Co-authored-by: emkornfield <micahk@google.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
I'm not sure why values_capacity_ is different kept separately from the buffer, but there is check which does not reserve capacity again values_capacity_ is already the needed size. When ReleaseValues is called, we allocate a brand new empty buffer. I'm not really sure why this hasn't caused users more issues (maybe increasingly large row groups or some other phenonemon). This bug also highlight that our C++ tests have very limited coverage on batched reads. To fix this I added an batch read for every round trip test to confirm it yields the same values. Closes apache#9498 from emkornfield/ARROW-11607 Lead-authored-by: Micah Kornfield <emkornfield@gmail.com> Co-authored-by: emkornfield <micahk@google.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why values_capacity_ is different kept separately
from the buffer, but there is check which does not reserve
capacity again values_capacity_ is already the needed size.
When ReleaseValues is called, we allocate a brand new empty buffer.
I'm not really sure why this hasn't caused users more issues (maybe
increasingly large row groups or some other phenonemon). This bug
also highlight that our C++ tests have very limited coverage on batched
reads. To fix this I added an batch read for every round trip test
to confirm it yields the same values.