Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-11607: [C++][Parquet] Update values_capacity_ when resetting. #9498

Closed
wants to merge 4 commits into from

Commits on Feb 15, 2021

  1. ARROW-11607: [C++][Parquet] Update values_capacity_ when resetting.

    I'm not sure why values_capacity_ is different kept separately
    from the buffer, but there is check which does not reserve
    capacity again values_capacity_ is already the needed size.
    When ReleaseValues is called, we allocate a brand new empty buffer.
    
    I'm not really sure why this hasn't caused users more issues (maybe
    increasingly large row groups or some other phenonemon). This bug
    also highlight that our C++ tests have very limited coverage on batched
    reads.  To fix this I added an batch read for every round trip test
    to confirm it yields the same values.
    emkornfield committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    716181f View commit details
    Browse the repository at this point in the history
  2. fix pythontest

    emkornfield committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    70aadcc View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. make test more succinct

    emkornfield committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    e2e1a00 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74961aa View commit details
    Browse the repository at this point in the history