-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG #9553
Conversation
@github-actions crossbow submit test-build-vcpkg-win wheel-manylinux2010-cp36m wheel-windows-cp36m |
Revision: 17c32d4 Submitted crossbow builds: ursacomputing/crossbow @ actions-172
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(My review isn't completed yet... I'll continue later.)
@github-actions crossbow submit test-build-vcpkg-win wheel-manylinux2010-cp36m wheel-windows-cp36m |
Revision: f5c21b3 Submitted crossbow builds: ursacomputing/crossbow @ actions-173
|
FYI, I have not attempted to thoroughly test and fix debug builds with vcpkg-installed dependencies, but I plan to do that in ARROW-11796. |
@kou let me know if there is anything I can do to help you complete your review. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It almost looks good to me!
I'm not sure many CACHE
are really needed.
Oh, sorry for my late review... |
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actions crossbow submit test-build-vcpkg-win wheel-manylinux2010-cp36m wheel-windows-cp36m |
Revision: d7f0e22 Submitted crossbow builds: ursacomputing/crossbow @ actions-178
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
We can merge this once CI is green.
@github-actions crossbow submit test-build-vcpkg-win wheel-manylinux2010-cp36m wheel-windows-cp36m |
Revision: 2e6905a Submitted crossbow builds: ursacomputing/crossbow @ actions-180
|
This builds upon ARROW-11340 and makes it simpler to use vcpkg for dependencies. Previously, to use vcpkg it was necessary to specify: - `-DARROW_DEPENDENCY_SOURCE=SYSTEM` - `-DCMAKE_TOOLCHAIN_FILE=/path/to/vcpkg.cmake` - `-DVCPKG_TARGET_TRIPLET=xxx-yyy-zzz` - Various`*_MSVC_*` variables on Windows - Various `*_ROOT`, `*_LIB`, and `*_INCLUDE` variables in some cases - `-D_VCPKG_INSTALLED_DIR=/path/to/vcpkg/installed/dir` in some cases Now all that is necessary is: - `-DARROW_DEPENDENCY_SOURCE=VCPKG` Other variables are now optional and can be specified to override default behaviors. After this is merged, I will make additional updates to the docs, focusing initially on Windows (ARROW-11336). Closes apache#9553 from ianmcook/ARROW-11580-take2 Authored-by: Ian Cook <ianmcook@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This builds upon ARROW-11340 and makes it simpler to use vcpkg for dependencies. Previously, to use vcpkg it was necessary to specify: - `-DARROW_DEPENDENCY_SOURCE=SYSTEM` - `-DCMAKE_TOOLCHAIN_FILE=/path/to/vcpkg.cmake` - `-DVCPKG_TARGET_TRIPLET=xxx-yyy-zzz` - Various`*_MSVC_*` variables on Windows - Various `*_ROOT`, `*_LIB`, and `*_INCLUDE` variables in some cases - `-D_VCPKG_INSTALLED_DIR=/path/to/vcpkg/installed/dir` in some cases Now all that is necessary is: - `-DARROW_DEPENDENCY_SOURCE=VCPKG` Other variables are now optional and can be specified to override default behaviors. After this is merged, I will make additional updates to the docs, focusing initially on Windows (ARROW-11336). Closes apache#9553 from ianmcook/ARROW-11580-take2 Authored-by: Ian Cook <ianmcook@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This builds upon ARROW-11340 and makes it simpler to use vcpkg for dependencies.
Previously, to use vcpkg it was necessary to specify:
-DARROW_DEPENDENCY_SOURCE=SYSTEM
-DCMAKE_TOOLCHAIN_FILE=/path/to/vcpkg.cmake
-DVCPKG_TARGET_TRIPLET=xxx-yyy-zzz
*_MSVC_*
variables on Windows*_ROOT
,*_LIB
, and*_INCLUDE
variables in some cases-D_VCPKG_INSTALLED_DIR=/path/to/vcpkg/installed/dir
in some casesNow all that is necessary is:
-DARROW_DEPENDENCY_SOURCE=VCPKG
Other variables are now optional and can be specified to override default behaviors.
After this is merged, I will make additional updates to the docs, focusing initially on Windows (ARROW-11336).