Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-11798: [Integration] Update testing submodule #9587

Closed
wants to merge 1 commit into from
Closed

ARROW-11798: [Integration] Update testing submodule #9587

wants to merge 1 commit into from

Conversation

nevi-me
Copy link
Contributor

@nevi-me nevi-me commented Feb 26, 2021

Updates the submodule for changes in ARROW-11666

@nevi-me nevi-me requested a review from pitrou February 26, 2021 18:58
@nevi-me
Copy link
Contributor Author

nevi-me commented Feb 26, 2021 •
edited
Loading

CC @pitrou @kiszk

I checked for "generated_large_batch" in the codebase, looks like it's only Rust that hardcodes the file name (still necessary for now). I'll rely on integration tests as a hint for what else to change.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-11798

@alamb alamb mentioned this pull request Feb 26, 2021
Closed
@nevi-me
ARROW-11798: [Integration] Update testing submodule
437f1ed 
Updates the submodule for changes in ARROW-11666
@pitrou
Copy link
Member

pitrou commented Mar 1, 2021

Thanks @nevi-me . I tested locally and the integration tests seem to pass.

pitrou
pitrou approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pitrou pitrou closed this in 41401b0 Mar 1, 2021
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
@nevi-me @GeorgeAp
ARROW-11798: [Integration] Update testing submodule
5233e01 
Updates the submodule for changes in ARROW-11666

Closes apache#9587 from nevi-me/ARROW-11798

Authored-by: Neville Dipale <nevilledips@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
@nevi-me @michalursa
ARROW-11798: [Integration] Update testing submodule
e3906c4 
Updates the submodule for changes in ARROW-11666

Closes apache#9587 from nevi-me/ARROW-11798

Authored-by: Neville Dipale <nevilledips@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimport asfimport mentioned this pull request Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
Component: Rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nevi-me @pitrou