ARROW-10250: [C++][FlightRPC] Consistently use FlightClientOptions::Defaults #9728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix the Python lint error? |
|
Done, sorry (I thought I ran archery locally…) |
cyb70289
requested changes
Mar 18, 2021
cyb70289
reviewed
Mar 19, 2021
cyb70289
reviewed
Mar 19, 2021
cyb70289
approved these changes
Mar 22, 2021
|
Will merge when CI finishes |
|
Thanks for the review. The integration test failure is a known one, see #9755. |
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…efaults This is a small follow up from PR apache#8325 to encourage always using a Defaults() method to avoid accidentally leaving fields uninitialized. Closes apache#9728 from lidavidm/arrow-10250 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Yibo Cai <yibo.cai@arm.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
…efaults This is a small follow up from PR apache#8325 to encourage always using a Defaults() method to avoid accidentally leaving fields uninitialized. Closes apache#9728 from lidavidm/arrow-10250 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Yibo Cai <yibo.cai@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small follow up from PR #8325 to encourage always using a Defaults() method to avoid accidentally leaving fields uninitialized.