ARROW-11908: [C++] Work around flaky integration by retrying #9755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
approved these changes
Mar 22, 2021
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
In principle I don't like tests which retry until they succeed, but in the meantime, flaky integration tests are making them a bad signal for maintainers. While the Rust side gets sorted out, this should paper over the issues. (It doesn't help that 'connected' in gRPC is (for reasonable reasons) nebulous, such that you don't get an actual connection error until you make a call.) (The main issue is that it appears Rust's gRPC server returns to application code before it's quite fully listening, so a fast-enough client like C++ might run into a server that's not quite ready yet.) Closes apache#9755 from lidavidm/arrow-11908 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
In principle I don't like tests which retry until they succeed, but in the meantime, flaky integration tests are making them a bad signal for maintainers. While the Rust side gets sorted out, this should paper over the issues. (It doesn't help that 'connected' in gRPC is (for reasonable reasons) nebulous, such that you don't get an actual connection error until you make a call.) (The main issue is that it appears Rust's gRPC server returns to application code before it's quite fully listening, so a fast-enough client like C++ might run into a server that's not quite ready yet.) Closes apache#9755 from lidavidm/arrow-11908 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In principle I don't like tests which retry until they succeed, but in the meantime, flaky integration tests are making them a bad signal for maintainers. While the Rust side gets sorted out, this should paper over the issues. (It doesn't help that 'connected' in gRPC is (for reasonable reasons) nebulous, such that you don't get an actual connection error until you make a call.)
(The main issue is that it appears Rust's gRPC server returns to application code before it's quite fully listening, so a fast-enough client like C++ might run into a server that's not quite ready yet.)