-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-12239: [JS] Switch to yarn #9918
Conversation
While I personally love yarn and prefer it over npm, I think we've stuck to using
Do tools like GH security alerts work with |
Yes, I have seen it with my projects and I only use yarn.
There is |
The failures look unrelated to my changes. Do you agree @trxcllnt? |
It seems that the following error is related to this: https://github.com/apache/arrow/pull/9918/checks?check_run_id=2298651927#step:7:367
|
@kou thanks! That came from a merge. I updated the lockfile. |
@kou There is an error |
It seems that the |
Go for it. You can also merge since we probably should squash this pull request anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I've fixed the integration test error.
Closes apache#9918 from domoritz/yarn Lead-authored-by: Dominik Moritz <domoritz@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Closes apache#9918 from domoritz/yarn Lead-authored-by: Dominik Moritz <domoritz@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Closes apache#9918 from domoritz/yarn Lead-authored-by: Dominik Moritz <domoritz@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
No description provided.