AVRO-2988: C: Include required libraries in Libs.private #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes this:
; pkg-config --libs --static avro-c
-L/install/dir -lavro
Into this:
; pkg-config --libs --static avro-c
-L/install/dir -lavro -lzma -ljansson -lpthreads
Assuming those are needed to link statically; pthreads may
or may not be there depending on the system, and so on.
Hugmeir
added a commit
to Hugmeir/p5-alien-libavro_c
that referenced
this pull request
Nov 25, 2020
apache/avro#1018 apache/avro#1019 apache/avro#1020 apache/avro#1021 Plus a patch to speed up compilation by skipping compiling the test binaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes this:
Into this:
Assuming those are needed to link statically; pthreads may
or may not be there depending on the system, and so on.