AVRO-1882: ConcurrentHashMap with non-string keys fails in Java 1.8 #113
Conversation
|
@sachingsachin, this looks fine to me, but I think the maven-shade-plugin change should be done in a separate issue and pull request. Could you open a new issue and separate that change out? Thanks! |
| @@ -17,15 +17,20 @@ | |||
| */ | |||
| package org.apache.avro.reflect; | |||
|
|
|||
| import static org.junit.Assert.assertEquals; | |||
| import static org.junit.Assert.assertNotNull; | |||
There was a problem hiding this comment.
Could you revert moving these static imports? If there's no need to reorder then it is easier for maintenance if we make as few changes as possible.
|
@sachingsachin, I found a couple of other minor things to fix. Once those are done I'll merge this. Thanks for taking the time to fix it! |
|
Thanks @rdblue for looking into this. |
|
@rdblue , its been a month since we collaborated on this. |
|
@sachingsachin, I've committed this. Please close the PR. Thanks for fixing this! |
|
Ryan Blue committed this as 420824c |
|
@sachingsachin, can you close this PR please? Thanks! |
The new MapEntry class removes any dependence on the Map.Entry internal fields which are liable to change between Java versions or between different implementations of Map interface.
Also updated maven-shade-plugin as per this thread