AVRO-3051: Reformatted C++ sources to make them consistent

[thiru-mg]

Make sure you have checked all steps below.

Jira

• My PR addresses the following Avro Jira issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
  • https://issues.apache.org/jira/browse/AVRO-3051
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason: This is a format-only change

Commits

• My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain Javadoc that explain what it does

[RyanSkraba]

Hello! I checked that there's no functional changes, just whitespace and formatting, so LGTM from that point. I have no opinion on the formatting used.

It would be great to put the name of the beautifier tool and/or settings in the lang/c++/readme file for future reference as a best practice. I find that very helpful when contributing to a new project!

[thiru-mg]

Hello! I checked that there's no functional changes, just whitespace and formatting, so LGTM from that point. I have no opinion on the formatting used.

It would be great to put the name of the beautifier tool and/or settings in the lang/c++/readme file for future reference as a best practice. I find that very helpful when contributing to a new project!

I added a new config file .clang-format and build target format. Now ./build.sh format will format the code provided clang-format has been installed on the system.

[RyanSkraba]

Awesome for the script, thanks! LGTM, I checked that:

1. m̀aster + .clang-format (1.10.1) with returns essentially the results in this branch (one or two whitespace choices), and
2. this commit is consistent with the rules provided: ./build.sh format doesn't make any diff

[emkornfield]

Skimmed and looks good to me, as well. A heads up to the ML might still be worthwhile because people like to bikeshed this stuff. As a follow-up it would be great to add a CI rule that verifies applying PRs are consistent with clang-format.